Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MATH-1559] Fix assertion failure with epsilon #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tongxin97
Copy link
Contributor

For detailed description of the issue, see: https://issues.apache.org/jira/browse/MATH-1559

If we just want to change the test so that it will always pass, this PR achieves it by setting a small epsilon (1e-15) in assertEquals(0.5, distribution.probability(2), 1e-15). Otherwise to fix the issue, the source code, in particular MathArrays.normalizeArray() needs change.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.713% when pulling bc61789 on tongxin97:fix-testCreateFromDoubles into 43b77ff on apache:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants