-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/math 1563 #197
base: master
Are you sure you want to change the base?
Feature/math 1563 #197
Conversation
MATH-1563/MATH-1618
ConvergenceListener
Thanks for the contribution. There are a few issues to address before a detailed review. This will fail on checkstyle. You should replace all tab characters with 4 spaces and add new lines at the end of files. You can run a checkstyle report using:
And then open Before the CI build will pass you can check that the local build passes the default goal. This is:
You can run the code check targets separately to get a report on what is wrong (outputs will be in the
In general you should check that the module passes the default maven goal:
You have public interfaces with redundant public keywords on methods or properties. There is a string property named CHROMOZOME which should be corrected. The module directory name The class RandomGenerator has a synchronized method to access a singleton. The effect of the synchronized keyword is meaningless here. The returned singleton is not thread-safe. A different design is required if the object is intended to be used across threads. A better approach is a single random generator per thread. The WELL_19937_C generator is not a very robust generator. There are faster and statistically better random generators available. For cross thread generic use you could try for example |
The following errors have been received after build. These are due to formatting of lambda expression. I have formatted the manually. It will be helpful if anyone can share eclipse configuration to resolve this. [INFO] There are 6 errors reported by Checkstyle 8.29 with /home/travis/build/apache/commons-math/commons-math4-genetics/../src/main/resources/checkstyle/checkstyle.xml ruleset. |
changed formatting
fixed build errors
commons-math-ga/pom.xml
Outdated
<artifactId>commons-math-parent</artifactId> | ||
<version>4.0-SNAPSHOT</version> | ||
</parent> | ||
<artifactId>commons-math4-ga</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the 4 from math4. The version is specified separately from the artifact ID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done and committed.
Changes for task MATH-1618