Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken unit tests due to strict Serializable interface restrictions #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tianshuang
Copy link

Because java.util.Map and java.util.Set do not implement the Serializable interface, but 99d689c imposes strict restrictions.

@codecov-commenter
Copy link

Codecov Report

Merging #60 (e24501b) into master (b8d2a8e) will increase coverage by 0.08%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master      #60      +/-   ##
============================================
+ Coverage     27.77%   27.85%   +0.08%     
- Complexity      561      566       +5     
============================================
  Files            93       93              
  Lines          6485     6487       +2     
  Branches       1077     1078       +1     
============================================
+ Hits           1801     1807       +6     
+ Misses         4449     4445       -4     
  Partials        235      235              
Impacted Files Coverage Δ
...ibaba/com/caucho/hessian/io/SerializerFactory.java 69.56% <75.00%> (+1.21%) ⬆️
...a/com/caucho/hessian/io/AbstractHessianOutput.java 33.33% <0.00%> (+3.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants