Issue-596: Holistic review of non-quarkus cloud chapter #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 062ee8c has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-625.surge.sh |
Review build-and-deploy-workflows Review configuring-workflows Review developing-workflows Review referencing-resource-files
Fix typoes in build and deploy workflows
Review building-custom-images Review customize-podspec Review workflow-status-conditions
domhanak
commented
May 22, 2024
| @@ -144,7 +122,7 @@ To uninstall the correct version of the operator, first you must get the current | |||
| ---- | |||
| kubectl get deployment sonataflow-operator-controller-manager -n sonataflow-operator-system -o jsonpath="{.spec.template.spec.containers[?(@.name=='manager')].image}" | |||
|
|
|||
| quay.io/kiegroup/kogito-serverless-operator-nightly:1.41.0 | |||
| quay.io/kiegroup/kogito-serverless-operator-nightly:latest | |||
There was a problem hiding this comment.
@ricardozanini noting these references, needs updates
ricardozanini
approved these changes
May 22, 2024
domhanak
commented
May 22, 2024
serverlessworkflow/modules/ROOT/pages/cloud/operator/referencing-resource-files.adoc
Outdated
Show resolved
Hide resolved
domhanak
commented
May 22, 2024
serverlessworkflow/modules/ROOT/pages/cloud/operator/referencing-resource-files.adoc
Outdated
Show resolved
Hide resolved
domhanak
commented
May 22, 2024
serverlessworkflow/modules/ROOT/pages/cloud/operator/referencing-resource-files.adoc
Outdated
Show resolved
Hide resolved
domhanak
commented
May 22, 2024
serverlessworkflow/modules/ROOT/pages/cloud/operator/supporting-services.adoc
Outdated
Show resolved
Hide resolved
domhanak
commented
May 22, 2024
serverlessworkflow/modules/ROOT/pages/cloud/operator/supporting-services.adoc
Outdated
Show resolved
Hide resolved
domhanak
commented
May 22, 2024
serverlessworkflow/modules/ROOT/pages/cloud/operator/supporting-services.adoc
Outdated
Show resolved
Hide resolved
domhanak
commented
May 22, 2024
serverlessworkflow/modules/ROOT/pages/cloud/operator/workflow-status-conditions.adoc
Outdated
Show resolved
Hide resolved
|
Found some extra flaws, apologies. 👀 suggestions |
wmedvede
approved these changes
May 22, 2024
serverlessworkflow/modules/ROOT/pages/cloud/operator/supporting-services.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/supporting-services.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/supporting-services.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/getting-started/preparing-environment.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Walter Medvedeo <[email protected]>
jakubschwan
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes/Fixes/Resolves #596
Description:
Improvement to cloud sections
Please make sure that your PR meets the following requirements:
Issue-XYZ Subject[0.9.x] Issue-XYZ SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.