Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-kogito-docs-672: Create a new SonataFlow guide for Knative Eventing Integration with Jobs Service and Data Index #639

Merged
merged 9 commits into from
May 29, 2024

Conversation

wmedvede
Copy link
Contributor

@wmedvede wmedvede commented May 27, 2024

Closes #627

Description:

Please make sure that your PR meets the following requirements:

  • You have read the contributions doc
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • The nav.adoc file has a link to this guide in the proper category
  • The index.adoc file has a card to this guide in the proper category, with a meaningful description
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…ng Integration with Jobs Service and Data Index
@wmedvede wmedvede requested review from domhanak and nmirasch and removed request for domhanak May 27, 2024 11:08
Copy link
Contributor

github-actions bot commented May 27, 2024

🎊 PR Preview ce2e35c has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-639.surge.sh

@wmedvede
Copy link
Contributor Author

Hi @kaldesai , would you mind review this PR?

Copy link
Contributor

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wmedvede and others added 4 commits May 27, 2024 15:42
…ng-knative-eventing-resources.adoc

Co-authored-by: Kalyani Desai <[email protected]>
…ng-knative-eventing-resources.adoc

Co-authored-by: Kalyani Desai <[email protected]>
…ng-knative-eventing-resources.adoc

Co-authored-by: Kalyani Desai <[email protected]>
…ng-knative-eventing-resources.adoc

Co-authored-by: Kalyani Desai <[email protected]>
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat! Just non-blocker comments.

namespace: example-namespace
----

:sectnums!:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a brief section explaining how to verify that the setup is working? Maybe pointing to another doc that shows that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can try to add something, but we are running out-of-time at the same time. I think, we should merge this, try to finish the revisting of the supporting services guide, and hopefully, add more stuff on this.

wmedvede and others added 4 commits May 29, 2024 19:03
…ng-knative-eventing-resources.adoc

Co-authored-by: Ricardo Zanini <[email protected]>
…ng-knative-eventing-resources.adoc

Co-authored-by: Ricardo Zanini <[email protected]>
…ng-knative-eventing-resources.adoc

Co-authored-by: Ricardo Zanini <[email protected]>
…ng-knative-eventing-resources.adoc

Co-authored-by: Ricardo Zanini <[email protected]>
@ricardozanini ricardozanini merged commit 21e7187 into apache:main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new SonataFlow guide for Knative Eventing Integration with Jobs Service and Data Index
4 participants