Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic dir handling in default shader #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rmannibucau
Copy link
Contributor

Follow up of #104 (comment) to share the idea (likely better than discussing).

@kriegaex
Copy link
Contributor

kriegaex commented Jul 21, 2021

Because the new PR has no description, I want to quickly describe it:

It solves MSHADE-366 in a more fundamental way than both #83 and #104, namely by adding the new feature of handling input directories and input JARs uniformly with regard to service provider minification, instead of simply avoiding to log irritating warnings when directories - most prominently, the own module's target/classes - are found on the classpath.

It addresses the then open question I raised in #83 (comment), in my MSHADE-366 comment and again in #104 (comment) as a reaction to @rmannibucau's corresponding question, making the warning a non-issue.

Therefore, this PR supersedes both of its predecessors. I am suggesting to finish it ASAP (if Romain thinks he still needs to change/improve anything), so we can review and merge it, in order to include it in the hopefully soon to be released Shade 3.3.0.

@kriegaex
Copy link
Contributor

kriegaex commented Jul 21, 2021

Sorry, I was a bit too fast with my enthusiasm: In its current state, this PR improves DefaultShader, but MSHADE-366 is about minification and the previous two PRs addressed warnings in MinijarFilter. I.e., while Romain's changes point the way towards unified file handling for directories and JARs, it is by no means used during minification yet. The old warning persists.

To do:

  • Unify resource handling in MinijarFilter, similarly to DefaultShader.
  • Refactor method MinijarFilter.removeService in a way similar to how I did it in PR 104, commit faa97df, extracting smaller methods from that big one.

@rmannibucau
Copy link
Contributor Author

@kriegaex updated a bit the PR but think it can be worth importing/adding your test on top of it to harness the code, do you want to do it and adjust the code if needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants