[MSHADE-318] - Include transitive dependencies #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarg
force-pushed
the
MSHADE-318
branch
2 times, most recently
from
394592f
to
8262abe
Compare
|
@khmarbaise Review please. :-) |
Includes all transitive dependencies of specifically included classes. Signed-off-by: Markus KARG <[email protected]>
|
@jvanzyl @olamy @brettporter Review please! :-) This issue is waiting for a review since one month. How are we supposed to work together if all my PRs are unprocessed for weeks? |
|
@struberg Review please. :-) |
eolivelli
approved these changes
May 20, 2019
|
@rfscholte @khmarbaise Ping ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MSHADE-318 - Specifically included class's dependencies are missing.
Solution: Include transitive dependencies of specifically included classes.