Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to asm 7.2 #29

Merged
merged 1 commit into from
Oct 12, 2019
Merged

upgrade to asm 7.2 #29

merged 1 commit into from
Oct 12, 2019

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Oct 11, 2019

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSHADE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSHADE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@Tibor17
Copy link
Contributor

Tibor17 commented Oct 11, 2019

Here is the release notes support for J13 and J14.
@rfscholte This version 7.2 should be set in https://github.com/codehaus-plexus/plexus-languages/blob/master/plexus-java/pom.xml#L70 as well and then we can release plugins which are dependent on plexus-java. Do you agree with updating plexus-java and cutting a new version 1.0.4?

@eolivelli
Copy link

What is the better approach?
Wait for a plexus release or patch this plugin?
I see pros and cons in both of the two ways

@Tibor17
Copy link
Contributor

Tibor17 commented Oct 12, 2019

@eolivelli Let's merge this fix and release this plugin. The Plexus Java is used in Surefire but it is Codehaus, not Maven gid.

@Tibor17
Copy link
Contributor

Tibor17 commented Oct 12, 2019

@sullis pls create Jira ticket and rewrite the commit message, thx.

@rfscholte
Copy link
Contributor

Do you agree with updating plexus-java and cutting a new version 1.0.4?

ASM is a direct dependency of maven-shade plugin, so this PR is correct. No need to worry about plexus-java, the ASM code won't be used.

Copy link

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Thank you all for clarification

@Tibor17
Copy link
Contributor

Tibor17 commented Oct 12, 2019

It's simple. I mentioned plexus-java because surefire is dependent on it and thus transitive dep ASM. So we have a common problem, updates due to new J13 and J14.

@rfscholte rfscholte merged commit 2f0eb5f into apache:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants