Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2185 Upgrade to Visual Studio 2022 #1635

Conversation

fgerlits
Copy link
Contributor

@fgerlits fgerlits commented Aug 18, 2023

The only real problem was FileSystemRepositoryTests, which relied on this STL bug: microsoft/STL#1511

In addition to that, I have

  • added /MP to the command line -- I'm not sure if this does anything, but maybe;
  • removed -fPIC from the command line, as it has no meaning on Windows;
  • fixed some compiler warnings
  • unified the Windows UTF-8 <-> UTF-16 conversions to all use the functions in UnicodeConversion.h, and moved it from extensions/windows-event-log to libminifi/utils.

For now, I have kept the VS2019 CI job and added a new VS2022 job. After MINIFICPP-2186, we can remove the VS2019 job.


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
cmake/BundledOSSPUUID.cmake Outdated Show resolved Hide resolved
libminifi/include/core/PropertyType.h Show resolved Hide resolved
libminifi/src/utils/tls/CertificateUtils.cpp Outdated Show resolved Hide resolved
@fgerlits fgerlits force-pushed the MINIFICPP-2185_Upgrade-to-Visual-Studio-2022 branch from ca4799c to f222b0f Compare August 22, 2023 15:16
@fgerlits fgerlits marked this pull request as draft August 30, 2023 09:26
@fgerlits
Copy link
Contributor Author

The string <-> wstring conversion functions in #1634 are better, so we should merge that PR first, and then I will merge those changes with this PR.

@fgerlits fgerlits force-pushed the MINIFICPP-2185_Upgrade-to-Visual-Studio-2022 branch 2 times, most recently from 2c28fa4 to 4e95ec6 Compare September 25, 2023 10:14
@fgerlits fgerlits marked this pull request as ready for review September 26, 2023 07:12
@fgerlits fgerlits force-pushed the MINIFICPP-2185_Upgrade-to-Visual-Studio-2022 branch from 8a32045 to 29a58eb Compare October 4, 2023 08:36
@fgerlits fgerlits force-pushed the MINIFICPP-2185_Upgrade-to-Visual-Studio-2022 branch from 29a58eb to 36540b3 Compare October 4, 2023 08:53
libminifi/src/utils/Cron.cpp Outdated Show resolved Hide resolved
@fgerlits fgerlits force-pushed the MINIFICPP-2185_Upgrade-to-Visual-Studio-2022 branch from 983890d to f43de46 Compare October 4, 2023 13:50
@szaszm szaszm closed this in ba1188d Oct 6, 2023
@fgerlits fgerlits deleted the MINIFICPP-2185_Upgrade-to-Visual-Studio-2022 branch January 10, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants