[ISSUE #194] Fix build error on aarch64/arm platform #338

yg0x01 · 2020-12-26T10:45:12Z

What is the purpose of the change

Fix build error on aarch64 platform

Brief changelog

The build.sh runs failed on arm64. I checked and fix some error, add some judgement logic on the point which could failed on arm64.

In CmakeList.txt there is -m32 and -m64 option for compile, but for arm64 this params should not exist. I add an option named BUILD_FOR_ARM and when it is ON there will no -m32/64 parameter which lead build error on arm. In build.sh we should add this option when detect arm platform.
Old openssl-1.1.1d build failed on arm, but 1.1.1i version fix the error, so we should update openssl version for arm.
Jsoncpp copy .a from x86_64-linux-gnu folder, but on arm it should be aarch64-linux-gnu.
Boost b2 tool have a option architecture for build arm. When we build from arm we should add it.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

vongosling · 2020-12-28T03:20:44Z

build.sh

@@ -29,7 +29,7 @@ declare fname_openssl="openssl*.tar.gz"
 declare fname_libevent="libevent*.zip"
 declare fname_jsoncpp="jsoncpp*.zip"
 declare fname_boost="boost*.tar.gz"
-declare fname_openssl_down="openssl-1.1.1d.tar.gz"
+declare fname_openssl_down="openssl-1.1.1i.tar.gz"


Do you have sufficient test with 1.1i?

Actually no. I don't have any idea to make sure 1.1.1i make everything right but it passed build.sh ExecutionTesting process and I use the .so/.a with python client in some simple scenarios (push/pull consumer and producer) on arm/x86_64. It all works fine. Maybe some more tests should be done but I can't find any documents or resource.

Thank you for your honesty, this pr will be followed up by the community for a long time until a convincible security test. I'm happy to follow up on it. If you have compilation problems, you could use the patch to bypass software defects :-)

Thanks. That's the best way to ensure stability.

There are many existing cves in 1.1.1d

OpenSSL is supposed to be dynamically linked. SDK should not care about the version of OpenSSL that is eventually used as long as they share compatible ABI.

ifplusor · 2020-12-27T07:50:05Z

CMakeLists.txt

-        list(APPEND CXX_FLAGS "-m64")
-    endif ()
+    option(BUILD_FOR_ARM "Build for arm64 platform" ON)
+    if (NOT ${BUILD_FOR_ARM} MATCHES "ON")


no “matches” is ok

ifplusor · 2020-12-29T02:48:56Z

build.sh

+    if [ "$(uname -m)" = "aarch64" ]; then
+      cp ${install_lib_dir}/lib/aarch64-linux-gnu/libjsoncpp.a ${install_lib_dir}/lib/
+    else
+      cp ${install_lib_dir}/lib/x86_64-linux-gnu/libjsoncpp.a ${install_lib_dir}/lib/
+    fi


It seems "$(uname -m)-linux-gnu" is better.

You are right. I will fix it.

AGSaidi · 2022-07-16T02:44:36Z

build.sh

@@ -29,7 +29,7 @@ declare fname_openssl="openssl*.tar.gz"
 declare fname_libevent="libevent*.zip"
 declare fname_jsoncpp="jsoncpp*.zip"
 declare fname_boost="boost*.tar.gz"
-declare fname_openssl_down="openssl-1.1.1d.tar.gz"
+declare fname_openssl_down="openssl-1.1.1i.tar.gz"


There are many existing cves in 1.1.1d

AGSaidi · 2022-07-16T02:45:16Z

CMakeLists.txt

-    else () #not-condition
-        list(APPEND CXX_FLAGS "-m64")
-    endif ()
+    option(BUILD_FOR_ARM "Build for arm64 platform" OFF)


Why not detect the Arm platform and if it's Arm then skip this code instead of having a build option that means people building for Arm need to know to set this?

AGSaidi · 2022-07-16T02:46:50Z

build.sh

  else
-    ./b2 -j$cpu_num cflags=-fPIC cxxflags=-fPIC --with-atomic --with-thread --with-system --with-chrono --with-date_time --with-log --with-regex --with-serialization --with-filesystem --with-locale --with-iostreams threading=multi link=static release install --prefix=${install_lib_dir}
+    if [ "$(uname -m)" = "aarch64" ]; then
+      ./b2 -j$cpu_num cflags=-fPIC cxxflags=-fPIC --with-atomic --with-thread --with-system --with-chrono --with-date_time --with-log --with-regex --with-serialization --with-filesystem --with-locale --with-iostreams threading=multi link=static release install --prefix=${install_lib_dir} architecture=arm


why is it necessary to pass architecture=arm when building boost natively?

leizhiyuan · 2024-01-04T07:39:54Z

What other problems are there at the moment? It is still necessary for some users to use it on a Mac arm.

leizhiyuan · 2024-01-04T09:35:11Z

now arm may be arm64

Your Name added 2 commits December 20, 2020 01:43

fix arm

11e3d7a

fix build on x86_64

5bd316e

vongosling approved these changes Dec 28, 2020

View reviewed changes

vongosling requested changes Dec 28, 2020

View reviewed changes

vongosling added disscuss Something undering disscussing refactor refactor functions labels Dec 29, 2020

remove debug

ac53d09

ifplusor reviewed Dec 29, 2020

View reviewed changes

yg0x01 and others added 3 commits December 29, 2020 10:59

BuildJsonCPP remove if use x86_64-linux-gnu

0d3a503

remove unnecessary MATCHES ON

0007e7e

BUILD_FOR_ARM should be OFF default

281e3fc

AGSaidi reviewed Jul 16, 2022

View reviewed changes

Sligcm mentioned this pull request Dec 21, 2023

能否release一个支持mac m2 的构建后的包非常感谢 #459

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ISSUE #194] Fix build error on aarch64/arm platform #338

[ISSUE #194] Fix build error on aarch64/arm platform #338

yg0x01 commented Dec 26, 2020 •

edited

Loading

vongosling Dec 28, 2020

yg0x01 Dec 28, 2020

vongosling Dec 29, 2020

yg0x01 Dec 29, 2020

AGSaidi Jul 16, 2022

lizhanhui Aug 9, 2022

ifplusor Dec 27, 2020

yg0x01 Dec 29, 2020

ifplusor Dec 29, 2020

yg0x01 Dec 29, 2020

AGSaidi Jul 16, 2022

AGSaidi Jul 16, 2022

AGSaidi Jul 16, 2022

leizhiyuan commented Jan 4, 2024

leizhiyuan commented Jan 4, 2024

[ISSUE #194] Fix build error on aarch64/arm platform #338

Are you sure you want to change the base?

[ISSUE #194] Fix build error on aarch64/arm platform #338

Conversation

yg0x01 commented Dec 26, 2020 • edited Loading

What is the purpose of the change

Brief changelog

Verifying this change

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leizhiyuan commented Jan 4, 2024

leizhiyuan commented Jan 4, 2024

yg0x01 commented Dec 26, 2020 •

edited

Loading