Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make message trace compatible with RocketMQ main project #399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

humkum
Copy link
Contributor

@humkum humkum commented Feb 7, 2022

What is the purpose of the change

#398

Brief changelog

  • Change trace topic to "RMQ_SYS_TRACE_TOPIC"
  • Add clientId field for Pub trace; Add clientId field for SubBefore trace; Add contextCode, timeStamp, groupName fields for SubAfter trace.

Verifying this change

image

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@@ -73,7 +74,7 @@ void ConsumeMessageHookImpl::executeHookBefore(ConsumeMessageContext* context) {
}
traceContext->setTimeStamp(UtilAll::currentTimeMillis());

std::string topic = TraceContant::TRACE_TOPIC + traceContext->getRegionId();
std::string topic = TraceContant::TRACE_TOPIC;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trace Topic is different for local and cloud in Java SDK :
private String getTraceTopicName(String regionId) {
AccessChannel accessChannel = AsyncTraceDispatcher.this.getAccessChannel();
if (AccessChannel.CLOUD == accessChannel) {
return TraceConstants.TRACE_TOPIC_PREFIX + regionId;
}

        return AsyncTraceDispatcher.this.getTraceTopicName();
    }

@BeautyyuYanli
Copy link
Contributor

relate to #393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants