Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang: fast to the ok state #295

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

guyinyou
Copy link
Contributor

@guyinyou guyinyou commented Dec 1, 2022

issue: #288

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guyinyou guyinyou force-pushed the dev_go_fast_to_the_ok_state branch 2 times, most recently from e48fdbb to 72721a0 Compare December 19, 2022 05:09
@codecov-commenter
Copy link

Codecov Report

Merging #295 (707ef99) into master (5d9e8c5) will decrease coverage by 0.53%.
The diff coverage is 55.55%.

@@             Coverage Diff              @@
##             master     #295      +/-   ##
============================================
- Coverage     35.87%   35.34%   -0.54%     
  Complexity      666      666              
============================================
  Files           220      220              
  Lines         11230    11236       +6     
  Branches        276      276              
============================================
- Hits           4029     3971      -58     
- Misses         6947     7007      +60     
- Partials        254      258       +4     
Flag Coverage Δ
golang 35.17% <55.55%> (-2.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
golang/simple_consumer.go 0.00% <0.00%> (ø)
golang/client.go 40.51% <62.50%> (-3.67%) ⬇️
golang/producer.go 52.80% <0.00%> (-10.62%) ⬇️
golang/producer_options.go 30.76% <0.00%> (-5.13%) ⬇️
golang/client_manager.go 71.42% <0.00%> (-2.31%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit d821b20 into apache:master Dec 19, 2022
lizhanhui pushed a commit that referenced this pull request Jan 10, 2023
* golang: fast to the ok state

* fix utest

Co-authored-by: guyinyou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants