Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to disable TLS #356

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Allow user to disable TLS #356

merged 1 commit into from
Feb 13, 2023

Conversation

aaron-ai
Copy link
Member

@aaron-ai aaron-ai commented Feb 9, 2023

Fixes #355

@codecov-commenter
Copy link

Codecov Report

Merging #356 (5e7e99c) into master (2ff904e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #356      +/-   ##
============================================
+ Coverage     33.94%   33.96%   +0.02%     
- Complexity      643      645       +2     
============================================
  Files           220      220              
  Lines         11439    11443       +4     
  Branches        277      278       +1     
============================================
+ Hits           3883     3887       +4     
  Misses         7306     7306              
  Partials        250      250              
Flag Coverage Δ
java 60.69% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/apache/rocketmq/client/java/impl/ClientImpl.java 44.62% <100.00%> (+0.17%) ⬆️
...e/rocketmq/client/java/impl/ClientManagerImpl.java 72.90% <100.00%> (ø)
...apache/rocketmq/client/java/rpc/RpcClientImpl.java 85.71% <100.00%> (+0.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-ai aaron-ai merged commit 67ea9d6 into apache:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to disable TLS
5 participants