Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix endpoints parsing in Go Client #444

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

imp2002
Copy link
Contributor

@imp2002 imp2002 commented Apr 1, 2023

Fix: #377

@imp2002
Copy link
Contributor Author

imp2002 commented Apr 2, 2023

@aaron-ai Hello, it's seems some network error on CI, could you help rerun CI and help review the PR, thanks☺️

@aaron-ai
Copy link
Member

aaron-ai commented Apr 2, 2023

@aaron-ai Hello, it's seems some network error on CI, could you help rerun CI and help review the PR, thanks☺️

@imp2002 Could you rebase the master branch to get the latest code? the misspell issue should has been fixed.

@aaron-ai
Copy link
Member

aaron-ai commented Apr 3, 2023

@imp2002 Great! Extracting multiple addresses from endpoints is the first step in solving this problem.

In fact, the specified implementations of gRPC allow a client/stub to bind to multiple IP addresses. For example, in C++, you can refer to here, and in Java, you can refer to the implementation of IpNameResolverFactory. Can you help us confirm how to implement this in Go?

@imp2002
Copy link
Contributor Author

imp2002 commented Apr 4, 2023

OK, I'll try it.

@aaron-ai aaron-ai added the Golang label Apr 4, 2023
@aaron-ai
Copy link
Member

aaron-ai commented Apr 4, 2023

@imp2002 You can comment at #377 , then I will assign it to you.

@francisoliverlee francisoliverlee self-assigned this Apr 6, 2023
@francisoliverlee francisoliverlee merged commit 0c9a9b3 into apache:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golang: 客户端不支持连接RocketMQ5集群
3 participants