Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the reentrant PushConsumer message receiving #547

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

aaron-ai
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #525

Brief Description

Set the attempt_id for ReceiveMessageRequest of the push consumer, and reuse the last attempt_id when the request times out.

How Did You Test This Change?

By unit testing.

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Merging #547 (cbc8f8f) into master (5d4a682) will decrease coverage by 25.51%.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##             master     #547       +/-   ##
=============================================
- Coverage     71.44%   45.94%   -25.51%     
- Complexity      663      667        +4     
=============================================
  Files           106      207      +101     
  Lines          6409    11503     +5094     
  Branches       2931     2933        +2     
=============================================
+ Hits           4579     5285      +706     
- Misses         1601     5988     +4387     
- Partials        229      230        +1     
Flag Coverage Δ
java 62.93% <50.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cketmq/client/java/impl/consumer/ConsumerImpl.java 72.50% <50.00%> (-0.61%) ⬇️
...mq/client/java/impl/consumer/ProcessQueueImpl.java 65.71% <50.00%> (-0.66%) ⬇️

... and 101 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

xdkxlk
xdkxlk previously approved these changes Jun 14, 2023
Copy link

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-ai aaron-ai merged commit cea5343 into apache:master Jun 21, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Design and implement a reentrant PushConsumer message receiving.
3 participants