General message engineering in Producer #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-ai
reviewed
Jul 5, 2023
| f"endpoints={endpoints}, messageId={message.message_id}, clientId={self.client_id}") | ||
| raise | ||
|
|
||
| if not isinstance(exception, TooManyRequestsException): |
There was a problem hiding this comment.
where is TooManyRequestsException?
python/rocketmq/producer.py
Outdated
| f"endpoints={endpoints}, messageId={message.message_id}, clientId={self.client_id}") | ||
| raise | ||
|
|
||
| if message.message_type == "Transaction": |
There was a problem hiding this comment.
Enumeration should be used here.
aaron-ai
reviewed
Jul 11, 2023
python/rocketmq/client.py
Outdated
| logger.info("finish") | ||
| break | ||
| except Exception as e: | ||
| logger.error(f"[Bug] unexpected exception raised during heartbeat, clientId={self.client_id}, Exception: {str(e)}") | ||
|
|
||
| def GetTotalRouteEndpoints(self): |
There was a problem hiding this comment.
Please use snake case naming rather than camel naming.
aaron-ai
reviewed
Jul 11, 2023
python/rocketmq/client.py
Outdated
| def get_client_config(self): | ||
| """ | ||
| Method to return client configuration. | ||
| """ | ||
| return self.client_config | ||
|
|
||
| async def OnTopicRouteDataFetched(self, topic, topicRouteData): |
aaron-ai
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
Regular heartbeat
done
Telemetry performs abnormal recovery
done
The retry of message sending
done
Failed node isolation
done
transaction & delay & fifo message
done
How Did You Test This Change?
run 4 tests in producer.py & test heartbeat & telemetry rebuild by hands