Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update out-of-date java client examples #627

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

kingkh1995
Copy link
Contributor

@kingkh1995 kingkh1995 commented Oct 18, 2023

Which Issue(s) This PR Fixes

no issue related

Brief Description

  1. java client producer examples have some out-of-date comments;
  2. add maxPollingSize limit in AsyncSimpleConsumerExample, to avoid "polling full" error.

How Did You Test This Change?

no need to test

@codecov-commenter
Copy link

Codecov Report

Merging #627 (8769f0a) into master (19a4afc) will decrease coverage by 8.72%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #627      +/-   ##
============================================
- Coverage     55.84%   47.12%   -8.72%     
- Complexity      664      668       +4     
============================================
  Files           259      207      -52     
  Lines         15580    12109    -3471     
  Branches       3859     3507     -352     
============================================
- Hits           8700     5706    -2994     
+ Misses         6633     6155     -478     
- Partials        247      248       +1     
Flag Coverage Δ
java 62.97% <ø> (+0.34%) ⬆️
nodejs ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 54 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aaron-ai
Copy link
Member

aaron-ai commented Nov 6, 2023

Thanks for you contribution @kingkh1995 . As for the maxPollingSize, it introduces more complexity to our example.

Overall, it looks good.

@aaron-ai aaron-ai merged commit 4b7c411 into apache:master Nov 6, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants