Adjust params sequence of SQLStatementContextFactory.newInstance() (#…

…32039)
apache · Jul 8, 2024 · 731ff75 · 731ff75
1 parent 304b809
commit 731ff75
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/SQLBindEngine.java b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/SQLBindEngine.java
@@ -60,7 +60,7 @@ public final class SQLBindEngine {
      * @return SQL statement context
      */
     public SQLStatementContext bind(final SQLStatement sqlStatement, final List<Object> params) {
-        return SQLStatementContextFactory.newInstance(metaData, params, bind(sqlStatement), currentDatabaseName);
+        return SQLStatementContextFactory.newInstance(metaData, bind(sqlStatement), params, currentDatabaseName);
     }
 
     private SQLStatement bind(final SQLStatement statement) {

diff --git a/.../org/apache/shardingsphere/infra/binder/context/statement/SQLStatementContextFactory.java b/.../org/apache/shardingsphere/infra/binder/context/statement/SQLStatementContextFactory.java
@@ -126,17 +126,17 @@ public final class SQLStatementContextFactory {
      * Create SQL statement context.
      *
      * @param metaData metadata
-     * @param params SQL parameters
      * @param sqlStatement SQL statement
+     * @param params SQL parameters
      * @param currentDatabaseName current database name
      * @return SQL statement context
      */
-    public static SQLStatementContext newInstance(final ShardingSphereMetaData metaData, final List<Object> params, final SQLStatement sqlStatement, final String currentDatabaseName) {
+    public static SQLStatementContext newInstance(final ShardingSphereMetaData metaData, final SQLStatement sqlStatement, final List<Object> params, final String currentDatabaseName) {
         if (sqlStatement instanceof DMLStatement) {
-            return getDMLStatementContext(metaData, params, (DMLStatement) sqlStatement, currentDatabaseName);
+            return getDMLStatementContext(metaData, (DMLStatement) sqlStatement, params, currentDatabaseName);
         }
         if (sqlStatement instanceof DDLStatement) {
-            return getDDLStatementContext(metaData, params, (DDLStatement) sqlStatement, currentDatabaseName);
+            return getDDLStatementContext(metaData, (DDLStatement) sqlStatement, params, currentDatabaseName);
         }
         if (sqlStatement instanceof DCLStatement) {
             return getDCLStatementContext((DCLStatement) sqlStatement, currentDatabaseName);
@@ -147,7 +147,7 @@ public static SQLStatementContext newInstance(final ShardingSphereMetaData metaD
         return new UnknownSQLStatementContext(sqlStatement);
     }
 
-    private static SQLStatementContext getDMLStatementContext(final ShardingSphereMetaData metaData, final List<Object> params, final DMLStatement sqlStatement, final String currentDatabaseName) {
+    private static SQLStatementContext getDMLStatementContext(final ShardingSphereMetaData metaData, final DMLStatement sqlStatement, final List<Object> params, final String currentDatabaseName) {
         if (sqlStatement instanceof SelectStatement) {
             return new SelectStatementContext(metaData, params, (SelectStatement) sqlStatement, currentDatabaseName, Collections.emptyList());
         }
@@ -181,7 +181,7 @@ private static SQLStatementContext getDMLStatementContext(final ShardingSphereMe
         throw new UnsupportedSQLOperationException(String.format("Unsupported SQL statement `%s`", sqlStatement.getClass().getSimpleName()));
     }
 
-    private static SQLStatementContext getDDLStatementContext(final ShardingSphereMetaData metaData, final List<Object> params, final DDLStatement sqlStatement, final String currentDatabaseName) {
+    private static SQLStatementContext getDDLStatementContext(final ShardingSphereMetaData metaData, final DDLStatement sqlStatement, final List<Object> params, final String currentDatabaseName) {
         if (sqlStatement instanceof CreateSchemaStatement) {
             return new CreateSchemaStatementContext((CreateSchemaStatement) sqlStatement);
         }