Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit tests for ExpressionSegmentBinder #28538

Closed
tuichenchuxin opened this issue Sep 21, 2023 · 14 comments · Fixed by #32043
Closed

Add more unit tests for ExpressionSegmentBinder #28538

tuichenchuxin opened this issue Sep 21, 2023 · 14 comments · Fixed by #32043
Assignees
Milestone

Comments

@tuichenchuxin
Copy link
Contributor

Hi community,

This issue is for #28487.

Aim

Add more unit tests for ExpressionSegmentBinder to test its public functions to improve unit test coverage.

Unit test coverage can be viewed at: https://app.codecov.io/gh/apache/shardingsphere

Basic Qualifications

  • Java
  • Maven
  • Junit
@Gowrishankar04
Copy link

Hi @tuichenchuxin,

I would like to work on this. can you please assign this to me?

Thanks

@strongduanmu
Copy link
Member

@Gowrishankar04 Welcome, I just assign it to you.

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Nov 13, 2023
@github-actions github-actions bot removed the stale label Dec 22, 2023
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Jan 27, 2024
@Divyansh200102
Copy link

Hi, @strongduanmu I tried working on this issue but I am facing this error during the building

image

@strongduanmu
Copy link
Member

@Divyansh200102 You can try ./mvnw clean install -Prelease -Dmaven.javadoc.skip=true -Djacoco.skip=true -T 1C -Drat.skip=true -Dmaven.test.skip=true first. Since we need Antlr generates code for SQL parsing.

@strongduanmu
Copy link
Member

Can you remove -Dmaven.javadoc.skip=true?

@Divyansh200102
Copy link

Divyansh200102 commented Jan 31, 2024

./mvnw clean install -Prelease -Dmaven.javadoc.skip=true -Djacoco.skip=true -T 1C -Drat.skip=true -Dmaven.test.skip=true

@strongduanmu the build failure is still coming shall I raise an issue?
image

image

@github-actions github-actions bot removed the stale label Jan 31, 2024
Copy link

github-actions bot commented Mar 1, 2024

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Mar 1, 2024
@SankarshanMishra
Copy link

hello Sir,
I would like to work on this issue Kindly assign me this issue also it is going to be my first opensource contribution so kindly guide me a little.
Thank You.

@strongduanmu
Copy link
Member

@Gowrishankar04 Welcome, I just assign this issue to you.

@SankarshanMishra
Copy link

SankarshanMishra commented Apr 19, 2024 via email

@SankarshanMishra
Copy link

Screenshot (575)
I dont know why I am unable to find the java file when claerly the location of the file is this Kindly help me out here a little shardingsphere\infra\binder\src\main\java\org\apache\shardingsphere\infra\binder\segment\expression\ExpressionSegmentBinder.java
Thank You

@AbnerHuang2
Copy link
Contributor

@strongduanmu Pls assign to me.

AbnerHuang2 added a commit to AbnerHuang2/shardingsphere that referenced this issue Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment