Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug #2312 #2320

Merged
merged 1 commit into from
May 5, 2019
Merged

fix bug #2312 #2320

merged 1 commit into from
May 5, 2019

Conversation

weiyuc
Copy link

@weiyuc weiyuc commented May 5, 2019 •
edited
Loading

Fixes #2312.

Changes proposed in this pull request:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7906

  • 3 of 7 (42.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 55.612%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/SQLBuilder.java 3 7 42.86%
Totals Coverage Status
Change from base Build 7905: -0.01%
Covered Lines: 8735
Relevant Lines: 15707
💛 - Coveralls

@tristaZero
Copy link
Contributor

Thanks for your contribution ☺, it solved the bug #2312.
After merging this pr, more working will be done to make it solved better.

@tristaZero tristaZero merged commit a446856 into apache:dev May 5, 2019
@terrymanu terrymanu added this to the 4.0.0.M2 milestone May 5, 2019
@Harper0122 Harper0122 mentioned this pull request May 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-RC2
Development

Successfully merging this pull request may close these issues.

If there is quoteCharacter for index name, sql can not be executed
4 participants
@weiyuc @coveralls @tristaZero @terrymanu