-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide plugin for ShardingSphere #1934
Conversation
You have ci issue? Then please send pull request to test repo after ci fixed |
...etwork/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
Show resolved
Hide resolved
Yes, I'm working into test repo now. |
@tuohai666 #1934 is going to merge, and @ascrutae will adjust test cases, so maybe make the concept a little different. Keep watching :) |
Great! |
Agent and auto tests are already updated to v2. |
Any progress? |
Hi Sheng, I've been working on this plugin and its integration test for several weeks one month ago. The plugin worked well in my hundreds of tests, but yes, it still can't pass the integration test. |
# Conflicts: # apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java # docker/config/component-libraries.yml # oap-server/server-starter/src/main/resources/component-libraries.yml
Here is the test report and validate logs |
Here is the test report and validate logs |
Here is the test report and validate logs |
Here is the test report and validate logs |
@ascrutae Thanks for your comments. Just reminder, test cases were updated and past in local. |
@tuohai666 He is on vacation since yesterday, and most of PMC too. So, let's finish this after that. Thanks. |
@tuohai666 Noticed project version updated. |
@wu-sheng Get it. |
Here is the test report and validate logs |
This PR is clear for me. It can merge after the test case merge |
Here is the test report and validate logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tuohai666 Update the supported-list document please, then I can merge this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
[Agent] Provide plugin for ShardingSphere 3.0.0 #1933
New feature or improvement
Provide plugin for ShardingSphere