Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide plugin for ShardingSphere #1934

Merged
merged 32 commits into from
May 15, 2019
Merged

Provide plugin for ShardingSphere #1934

merged 32 commits into from
May 15, 2019

Conversation

tuohai666
Copy link
Member

@tuohai666 tuohai666 commented Nov 19, 2018 •
edited
Loading

Please answer these questions before submitting pull request

New feature or improvement

  • Describe the details and related test reports.
    Provide plugin for ShardingSphere

@coveralls
Copy link

coveralls commented Nov 19, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 16.535% when pulling abe5ff7 on tuohai666:master into 91ffae2 on apache:master.

@wu-sheng
Copy link
Member

You have ci issue? Then please send pull request to test repo after ci fixed

@wu-sheng wu-sheng added agent Language agent related. feature New feature labels Nov 19, 2018
@tuohai666
Copy link
Member Author

You have ci issue? Then please send pull request to test repo after ci fixed

Yes, I'm working into test repo now.

@wu-sheng
Copy link
Member

@tuohai666 #1934 is going to merge, and @ascrutae will adjust test cases, so maybe make the concept a little different. Keep watching :)

@tuohai666
Copy link
Member Author

@tuohai666 #1934 is going to merge, and @ascrutae will adjust test cases, so maybe make the concept a little different. Keep watching :)

Great!

@wu-sheng
Copy link
Member

Agent and auto tests are already updated to v2.

@tuohai666 tuohai666 mentioned this pull request Nov 26, 2018
Merged
@wu-sheng
Copy link
Member

Any progress?

@tuohai666
Copy link
Member Author

Any progress?

Hi Sheng,

I've been working on this plugin and its integration test for several weeks one month ago. The plugin worked well in my hundreds of tests, but yes, it still can't pass the integration test.
Please keep it open. I'll continuously working to finish the integration tests.

@tuohai666
Merge remote-tracking branch 'upstream/master'
fa302de 
# Conflicts:
#	apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
#	docker/config/component-libraries.yml
#	oap-server/server-starter/src/main/resources/component-libraries.yml
@tuohai666
Update to 6.0.0-GA-SNAPSHOT (#1933)
d8b4eee
@tuohai666
Update io.shardingsphere version to [3.0.0,) (#1933)
d9e5e67
@SkyWalkingRobot
Copy link

Here is the test report and validate logs

@SkyWalkingRobot
Copy link

Here is the test report and validate logs

@SkyWalkingRobot
Copy link

Here is the test report and validate logs

@SkyWalkingRobot
Copy link

Here is the test report and validate logs

@tuohai666
Copy link
Member Author

@ascrutae Thanks for your comments. Just reminder, test cases were updated and past in local.

@wu-sheng
Copy link
Member

@tuohai666 He is on vacation since yesterday, and most of PMC too. So, let's finish this after that. Thanks.

@wu-sheng
Copy link
Member

@tuohai666 Noticed project version updated.

@tuohai666
Copy link
Member Author

@wu-sheng Get it.

@Harper0122 Harper0122 mentioned this pull request May 13, 2019
Closed
@SkyWalkingRobot
Copy link

Here is the test report and validate logs

ascrutae
ascrutae previously approved these changes May 15, 2019
View reviewed changes
@ascrutae
Copy link
Member

This PR is clear for me. It can merge after the test case merge

@SkyWalkingRobot
Copy link

Here is the test report and validate logs

wu-sheng
wu-sheng reviewed May 15, 2019
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuohai666 Update the supported-list document please, then I can merge this pull request.

wu-sheng
wu-sheng approved these changes May 15, 2019
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit c7c1774 into apache:master May 15, 2019
@Harper0122 Harper0122 mentioned this pull request May 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@ascrutae ascrutae ascrutae left review comments

@hanahmily hanahmily Awaiting requested review from hanahmily

@candyleer candyleer Awaiting requested review from candyleer

Assignees
No one assigned
Labels
agent Language agent related. feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tuohai666 @coveralls @wu-sheng @SkyWalkingRobot @zhaoyuguang @ascrutae