-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Deprecating ENABLE_FLASK_COMPRESS #10233
chore: Deprecating ENABLE_FLASK_COMPRESS #10233
Conversation
f116c97
to
94ada9d
Compare
@@ -228,7 +228,7 @@ Note that the development web | |||
server (`superset run` or `flask run`) is not intended for production use. | |||
|
|||
If not using gunicorn, you may want to disable the use of flask-compress | |||
by setting `ENABLE_FLASK_COMPRESS = False` in your `superset_config.py` | |||
by setting `COMPRESS_REGISTER = False` in your `superset_config.py` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add COMPRESS_REGISTER to the config.py
I tend to use the config.py as a documentation for the available configuration options.
and add the link in the comments: https://github.com/colour-science/flask-compress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkyryliuk historically config.py
hasn't enumerated all the various Flask configs but rather only defines those which differ from the defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG%nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM. More generally, I'm wondering if it makes sense to avoid doing too much on the Flask app config and instructing people to use I'm pro having good default, but generally against having the burden of resurfacing / managing all those options... |
Co-authored-by: John Bodley <[email protected]>
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
This PR reverts the logic in #4617 as the Flask-Compress extension includes a
COMPRESS_REGISTER
option (default isTrue
) which enables or disables compression when the extension is initialized.TEST PLAN
CI.
ADDITIONAL INFORMATION