-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(permissions): alpha role has all full features #10241
Conversation
By adding the MVs in |
That was my objective, since by removing the "Manage" menu item, it's kind of implied the user does not have access to the But seems like we are using the old API for the annotations. Would be awesome to instead of removing we would add the "Manager" menu item to Alpha, that would make it more consistent, and inline with the idea that an Alpha user has access to all features except security |
I think users still access the API in some other ways though (dashboard / explore / SQL Lab), we'd have to check/confirm whether they hit the modelview endpoints or not. |
@mistercrunch , I've reverted the direction here. I'm adding the Manage menu and it's subitems to the alpha role. What do you think? |
+1 on a unit test, do we have a doc somewhere that give an idea of what |
Good points, I'll add both. I think we don't have a doc describing what roles are, I'll create one on the docs if it does not exist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the scope of Alpha permissions. This also needs a rebase.
# Conflicts: # UPDATING.md
* fix(permissions): alpha role is inconsistent * reverse and allow Alpha to access manager menu * Bump FAB to 3.0.1rc1 to include del permission fix * add docs, tests and UPDATING * EOL * Fix query view for Alpha
SUMMARY
Currently Alpha role does not include the "Manage" menu and it's sub items. But user's still have underlying access to the ModelView's that are included on the "Manager" menu. This PR proposes adding "Manage" menu and their sub items to the "Alpha" Role, making it an "All features included" role, except for security and SQLLab.
ADDITIONAL INFORMATION