-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(thumbnails): missing field, logging and new config var #10562
Conversation
"table.default_endpoint", | ||
"table.table_name", | ||
"thumbnail_url", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorted and added a new field thumbnail_url
superset/config.py
Outdated
@@ -797,6 +797,8 @@ class CeleryConfig: # pylint: disable=too-few-public-methods | |||
|
|||
# Any config options to be passed as-is to the webdriver | |||
WEBDRIVER_CONFIGURATION: Dict[Any, Any] = {} | |||
# The webdriver to use supports "chrome" and "firefox" | |||
WEBDRIVER_TYPE = "firefox" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use EMAIL_REPORTS_WEBDRIVER or just converge those 2
easy solution would be:
WEBDRIVER_TYPE = EMAIL_REPORTS_WEBDRIVER
or
EMAIL_REPORTS_WEBDRIVER = WEBDRIVER_TYPE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe took it too far, but I actually removed it now. Tell me if it's ok by you @bkyryliuk
Codecov Report
@@ Coverage Diff @@
## master #10562 +/- ##
==========================================
+ Coverage 60.10% 64.26% +4.15%
==========================================
Files 775 775
Lines 36528 36529 +1
Branches 3459 3459
==========================================
+ Hits 21955 23474 +1519
+ Misses 14382 12943 -1439
+ Partials 191 112 -79
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -790,7 +790,7 @@ class CeleryConfig: # pylint: disable=too-few-public-methods | |||
# chrome: | |||
# Requires: headless chrome | |||
# Limitations: unable to generate screenshots of elements | |||
EMAIL_REPORTS_WEBDRIVER = "firefox" | |||
WEBDRIVER_TYPE = "firefox" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional: change default to "chrome"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would, but: https://github.com/apache/incubator-superset/blob/master/docs/installation.rst#email-reports
States that firefox
is preferred, is it reasonable to change the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there are unresolved rendering errors on Firefox. Might not be applicable for thumbs, but worth mentioning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -790,7 +790,7 @@ class CeleryConfig: # pylint: disable=too-few-public-methods | |||
# chrome: | |||
# Requires: headless chrome | |||
# Limitations: unable to generate screenshots of elements | |||
EMAIL_REPORTS_WEBDRIVER = "firefox" | |||
WEBDRIVER_TYPE = "firefox" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there are unresolved rendering errors on Firefox. Might not be applicable for thumbs, but worth mentioning.
SUMMARY
PR with a couple of minor fixes:
thumbnail_url
to the list chart APIADDITIONAL INFORMATION