-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup FAB update perms #11155
chore: cleanup FAB update perms #11155
Conversation
3172ff8
to
7dd3679
Compare
7dd3679
to
8b91b26
Compare
@@ -552,7 +552,6 @@ def configure_fab(self) -> None: | |||
appbuilder.indexview = SupersetIndexView | |||
appbuilder.base_template = "superset/base.html" | |||
appbuilder.security_manager_class = custom_sm | |||
appbuilder.update_perms = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8b91b26
to
6051fd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, using just FAB_UPDATE_PERMS
config key is more flexible, but we assume no one wants to run superset that way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for keeping the codebase/docs clean! 🧹 ❤️
* chore: Using cache factory method * chore: Deprecate outdated FAB_UPDATE_PERMS information Co-authored-by: John Bodley <[email protected]>
SUMMARY
Superset has now configured FAB correctly in terms of when permissions should be updated, i.e., by default they shouldn't (per here) and only updated when running
superset init
(per here) and thus it seems the documentation regardingFAB_UPDATE_PERMS
is obsolete (it was originally added for a use case prior to FAB 2.0).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
CI.
ADDITIONAL INFORMATION