-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: turn SQL templating off by default #11172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non blocking nit, LGTM.
Co-authored-by: Ville Brofeldt <[email protected]>
UPDATING.md
Outdated
@@ -23,6 +23,8 @@ assists people when migrating to a new version. | |||
|
|||
## Next | |||
|
|||
* [10887](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default. To turn it on set `ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while you're in here, could you move the existing Next
stuff to 0.37.2
? Looks like that wasn't done yet.
Also, make sure you update the PR number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked, and the UPDATING is absolutely correct, there are no warning or breaking changes on 0.37.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, gotcha. i forgot that 0.37.2 was only cherrypicked PRs
…fix/disable-sql-templates # Conflicts: # UPDATING.md
Codecov Report
@@ Coverage Diff @@
## master #11172 +/- ##
==========================================
- Coverage 65.57% 61.49% -4.09%
==========================================
Files 828 828
Lines 39162 39164 +2
Branches 3694 3589 -105
==========================================
- Hits 25681 24084 -1597
- Misses 13371 14900 +1529
- Partials 110 180 +70
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@dpgaspar I think it's OK to merge this once conflicts are resolved |
* feat: possible to turn off SQL templating * turn SQL templating off by default * Update UPDATING.md Co-authored-by: Ville Brofeldt <[email protected]> * fix missing PR number * fix missing PR number Co-authored-by: Ville Brofeldt <[email protected]>
In the 1.0 release of superset template processing was changed from default enabled to default disabled[1]. Turn this back on as templating is useful in a variety of situations to build more dynamic and more efficient dashboards. [1] apache/superset#11172) Bug: T312134 Change-Id: I984d4ee70154e3cb83255fec043360d5dd28fa7e
SUMMARY
Use a new feature flag to make it possible to enable/disable SQL templating.
Note:
Setting is off by default
ADDITIONAL INFORMATION