-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make config ENABLE_REACT_CRUD_VIEWS = True by default #11259
Conversation
React CRUD views have been maturing for a while and are ready for prime time!
76be04c
to
78581fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #11259 +/- ##
==========================================
+ Coverage 60.70% 65.57% +4.87%
==========================================
Files 393 831 +438
Lines 24820 39511 +14691
Branches 0 3598 +3598
==========================================
+ Hits 15066 25908 +10842
- Misses 9754 13494 +3740
- Partials 0 109 +109
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@mistercrunch mind holding off on this for a day or two for us to verify in our environment that everything works as expected? We might mind some further bugs worth addressing before making it the community wide default (although I know we can always simply disable it too) |
Sounds good @etr2460 , this PR will be right here ready to merge :) |
excited about this change ! we have been using react views for quite some time at dropbox |
Thanks @mistercrunch! I added a few bugs I found through a precursory QA pass, but otherwise it looks much more feature complete than a few months ago. You can decide which of these (if any) are blocking, then feel free to merge! |
@nytai ^^^ |
It appears only these two are still open:
Overall the new experience is much better and been used in production at scale in many environments. It's also mentioned in UPDATING.md as a reminder. Merign! |
@mistercrunch Maybe we should modify |
Hi @mistercrunch I think this change caused problems in pre-commit mypy:
Problem appears only when |
revert? unclear why |
…11259) React CRUD views have been maturing for a while and are ready for prime time!
React CRUD views have been maturing for a while and are ready for prime time.