-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rls): move to feature flag and disable related view #11575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11575 +/- ##
==========================================
- Coverage 59.59% 59.57% -0.03%
==========================================
Files 832 832
Lines 40482 40481 -1
Branches 3666 3666
==========================================
- Hits 24126 24117 -9
- Misses 16187 16195 +8
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
d908993
to
bcfb47a
Compare
bcfb47a
to
44a8649
Compare
dpgaspar
reviewed
Nov 5, 2020
dpgaspar
approved these changes
Nov 5, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* chore(rls): move to feature flag and disable related view * rename feature flag
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Minor refinements to Row Level Security (RLS) implementation:
ENABLE_ROW_LEVEL_SECURITY
from config flag to feature flag.Row Level Security
andRow Level Security Filters
view menus for other users thanAdmin
.TEST PLAN
Local testing
ADDITIONAL INFORMATION