-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(charts): security perm simplification #11981
feat(charts): security perm simplification #11981
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11981 +/- ##
==========================================
- Coverage 67.88% 63.82% -4.07%
==========================================
Files 948 953 +5
Lines 46177 46705 +528
Branches 4405 4577 +172
==========================================
- Hits 31348 29809 -1539
- Misses 14722 16711 +1989
- Partials 107 185 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Pvm("SliceModelView", "can_download",): (Pvm("Chart", "can_read"),), | ||
Pvm("SliceModelView", "muldelete",): (Pvm("Chart", "can_write"),), | ||
Pvm("SliceModelView", "can_mulexport",): (Pvm("Chart", "can_read"),), | ||
Pvm("SliceModelView", "can_favorite_status",): (Pvm("Chart", "can_write"),), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm...should this be "can_read"? Does favoriting a chart do anything other than create a record of the favorite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should, actually that's a GET so it's really a mistake. Very nice catch
…incubator-superset into feat/security-converge-charts
SUMMARY
security permission simplification. Scope
Charts
for API and MVC FAB classes.Existing permissions:
Future permissions:
TEST PLAN
ADDITIONAL INFORMATION