feat(charts): security perm simplification #11981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11981 +/- ##
==========================================
- Coverage 67.88% 63.82% -4.07%
==========================================
Files 948 953 +5
Lines 46177 46705 +528
Branches 4405 4577 +172
==========================================
- Hits 31348 29809 -1539
- Misses 14722 16711 +1989
- Partials 107 185 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willbarrett
reviewed
Dec 9, 2020
| Pvm("SliceModelView", "can_download",): (Pvm("Chart", "can_read"),), | ||
| Pvm("SliceModelView", "muldelete",): (Pvm("Chart", "can_write"),), | ||
| Pvm("SliceModelView", "can_mulexport",): (Pvm("Chart", "can_read"),), | ||
| Pvm("SliceModelView", "can_favorite_status",): (Pvm("Chart", "can_write"),), |
There was a problem hiding this comment.
Hmm...should this be "can_read"? Does favoriting a chart do anything other than create a record of the favorite?
There was a problem hiding this comment.
it should, actually that's a GET so it's really a mistake. Very nice catch
…incubator-superset into feat/security-converge-charts
willbarrett
approved these changes
Dec 14, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
security permission simplification. Scope
Chartsfor API and MVC FAB classes.Existing permissions:
Future permissions:
TEST PLAN
ADDITIONAL INFORMATION