feat(datasets): security perm simplification #12000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12000 +/- ##
===========================================
- Coverage 63.72% 53.11% -10.61%
===========================================
Files 958 438 -520
Lines 47103 15746 -31357
Branches 4609 4077 -532
===========================================
- Hits 30016 8364 -21652
+ Misses 16903 7382 -9521
+ Partials 184 0 -184
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dpgaspar
commented
Dec 11, 2020
| @@ -1086,7 +1100,7 @@ def test_export_dataset_gamma(self): | |||
|
|
|||
| self.login(username="gamma") | |||
| rv = self.client.get(uri) | |||
| assert rv.status_code == 401 | |||
| assert rv.status_code == 404 | |||
There was a problem hiding this comment.
@betodealmeida export and import datasets will not need a separate permission now. import needs can_write on Dataset and export can_read on Dataset
willbarrett
approved these changes
Dec 14, 2020
# Conflicts: # superset/constants.py # tests/security_tests.py
# Conflicts: # tests/security_tests.py
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
security permission simplification. Scope
Datasetsfor API and MVC FAB classes.Existing permissions:
Future permissions:
WARNING: Don't merge freely, there are concurrent security converge PR's open, and the parent revision need to be updated once one is merged.
ADDITIONAL INFORMATION