fix: Stabilize and deprecate legacy alerts module #12627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craig-rueda
approved these changes
Jan 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #12627 +/- ##
==========================================
- Coverage 66.79% 66.72% -0.07%
==========================================
Files 1015 1017 +2
Lines 49673 49734 +61
Branches 4845 4864 +19
==========================================
+ Hits 33179 33187 +8
- Misses 16372 16424 +52
- Partials 122 123 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dpgaspar
approved these changes
Jan 21, 2021
| @@ -844,8 +846,8 @@ def schedule_alerts() -> None: | |||
| resolution = 0 | |||
| now = datetime.utcnow() | |||
| start_at = now - timedelta( | |||
| seconds=3600 | |||
| ) # process any missed tasks in the past hour | |||
| seconds=300 | |||
There was a problem hiding this comment.
would be nice to have this on a config flag
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 21, 2021
* Add deprecation notice to superset.tasks.schedules * Reduce retries and schedule window for alerts (cherry picked from commit e4ae17d)
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 25, 2021
* Add deprecation notice to superset.tasks.schedules * Reduce retries and schedule window for alerts (cherry picked from commit e4ae17d)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We are seeing exponential growth of
alert.run_querytasks in our Celery queues, likely due to the permissive scheduling window combined with multiple task retries. This PR 1) reduces the schedule window from 1hr to a few minutes, 2) reduces the retry count from 5 to 1, and 3) removes the arbitrarysoft_time_limitvalue.Also adding a deprecation notice to this module, as it's been replaced by #11711
TEST PLAN
Alert scheduling should function without exponential growth of celery task queues.
ADDITIONAL INFORMATION