-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): pie chart label bugs #13052
fix(explore): pie chart label bugs #13052
Conversation
e8c0680
to
a838414
Compare
a838414
to
673aa73
Compare
.map(type => ({ | ||
key: type, | ||
value: registry.get(type), | ||
})) | ||
.concat( | ||
registry | ||
.entries() | ||
.filter(entry => !entry.value.isNativeFilter) | ||
.filter(entry => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be move it to some utils like
const getVisibleCharts = ({ behaviours } = {}) => behaviors?.includes(Behavior.CROSS_FILTER) || !behaviors?.length;
and use it like:
.filter(type =>getVisibleCharts(registry.get(type)))
and
.filter(entry =>getVisibleCharts(entry.value))
84f51b8
to
d7aae26
Compare
d7aae26
to
4fbb2a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #13052 +/- ##
==========================================
+ Coverage 53.06% 61.85% +8.79%
==========================================
Files 489 546 +57
Lines 17314 20157 +2843
Branches 4482 5272 +790
==========================================
+ Hits 9187 12469 +3282
+ Misses 8127 7475 -652
- Partials 0 213 +213
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* master: (30 commits) refactor(native-filters): decouple params from filter config modal (first phase) (apache#13021) fix(native-filters): set currentValue null when empty (apache#13000) Custom superset_config.py + secret envs (apache#13096) Update http error code from 400 to 403 (apache#13061) feat(native-filters): add storybook entry for select filter (apache#13005) feat(native-filters): Time native filter (apache#12992) Force pod restart on config changes (apache#13056) feat(cross-filters): add cross filters (apache#12662) fix(explore): Enable selecting an option not included in suggestions (apache#13029) Improves RTL configuration (apache#13079) Added a note about the ! prefix for breaking changes to CONTRIBUTING.md (apache#13083) chore: lock down npm to v6 (apache#13069) fix: API tests, make them possible to run independently again (apache#13076) fix: add config to disable dataset ownership on the old api (apache#13051) add required * indicator to message content/notif method (apache#12931) fix: Retroactively add granularity param to charts (apache#12960) fix(ci): multiline regex in change detection (apache#13075) feat(style): hide dashboard header by url parameter (apache#12918) fix(explore): pie chart label bugs (apache#13052) fix: Disabled state button transition time (apache#13008) ...
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Bump
superset-ui
packages to version 0.17.8 and fix a the following Pie Chart bugs:label_type
in the plugin butpie_label_type
in the control panel. To fix this, the generic name was chosen (will make it easier to reuse the control value later when switching between chart types) and all references topie_label_type
in exising chart metadata was renamed tolabel_type
.Also updates some unrelated code that depends on changes to
superset-ui/core
that relate to native filter metadata.TEST PLAN
Verify that both up and down migration works, and that pie chart works properly.
ADDITIONAL INFORMATION