-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: deprecate old alerts and dash/charts reports #13440
docs: deprecate old alerts and dash/charts reports #13440
Conversation
superset/config.py
Outdated
@@ -614,18 +615,8 @@ class CeleryConfig: # pylint: disable=too-few-public-methods | |||
CELERY_ACKS_LATE = False | |||
CELERY_ANNOTATIONS = { | |||
"sql_lab.get_sql_results": {"rate_limit": "100/s"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these removals break SEMVER - we shouldn't change the defaults for the configuration between majors. Let's keep the schedules, but perhaps add a deprecation?
EMAIL_ASYNC_TIME_LIMIT_SEC = 300 | ||
|
||
# Email report configuration | ||
# From address in emails | ||
EMAIL_REPORT_FROM_ADDRESS = "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment with these config removals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is used anywhere, safe to just remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after we update to conform to SEMVER
Codecov Report
@@ Coverage Diff @@
## master #13440 +/- ##
==========================================
- Coverage 72.69% 71.71% -0.98%
==========================================
Files 903 804 -99
Lines 45611 40651 -4960
Branches 5501 4159 -1342
==========================================
- Hits 33156 29153 -4003
+ Misses 12243 11498 -745
+ Partials 212 0 -212
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@dpgaspar looks like this just needs a lint fix. |
* docs: deprecated old alerts and dash/charts reports * revert celery default config * fix lint
SUMMARY
Deprecates the old alerts and reports feature
ADDITIONAL INFORMATION