-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to Node 16 #16809
chore: upgrade to Node 16 #16809
Conversation
084a41e
to
2d74ac9
Compare
ee99dfa
to
b6c905e
Compare
b6c905e
to
902e57f
Compare
Codecov Report
@@ Coverage Diff @@
## master #16809 +/- ##
==========================================
- Coverage 76.89% 76.88% -0.01%
==========================================
Files 1005 1005
Lines 54169 54166 -3
Branches 7456 7456
==========================================
- Hits 41653 41648 -5
- Misses 12272 12273 +1
- Partials 244 245 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true |
@villebro Ephemeral environment spinning up at http://34.220.179.110:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the upgrade!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in local. Tested linked superset-ui repo.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
* chore: upgrade to Node 16 * add docs * fix test
#16809 updated node version but it didn't update nvmrc.
#16809 updated node version but it didn't update nvmrc.
* chore: upgrade to Node 16 * add docs * fix test
#16809 updated node version but it didn't update nvmrc.
SUMMARY
With Node 16 being the currently recommended version since 2021-04-20 and becoming the LTS supported version on 2021-10-26, it makes sense to migrate to this version to get all the benefits available in the new release:
https://medium.com/the-node-js-collection/node-js-16-available-now-7f5099a97e70
Also removes the workaround for pulling in
npm@7
in #16748 (npm 7 ships by default with Node 16)This PR also fixes some tests that were previously passing but contained unhandled promise rejections. Previously these only emitted warnings, but as of Node 15 these caused errors.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION