Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Node 16 #16809

Merged
merged 3 commits into from
Sep 25, 2021
Merged

chore: upgrade to Node 16 #16809

merged 3 commits into from
Sep 25, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Sep 23, 2021

SUMMARY

With Node 16 being the currently recommended version since 2021-04-20 and becoming the LTS supported version on 2021-10-26, it makes sense to migrate to this version to get all the benefits available in the new release:
https://medium.com/the-node-js-collection/node-js-16-available-now-7f5099a97e70
Also removes the workaround for pulling in npm@7 in #16748 (npm 7 ships by default with Node 16)

This PR also fixes some tests that were previously passing but contained unhandled promise rejections. Previously these only emitted warnings, but as of Node 15 these caused errors.

TESTING INSTRUCTIONS

  1. Make sure the application works as expected - done (running on the new build):
    image
  2. Make sure CI is reporting the correct versions - done:
    image

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro force-pushed the villebro/node-16 branch 2 times, most recently from ee99dfa to b6c905e Compare September 24, 2021 07:29
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #16809 (902e57f) into master (997320a) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16809      +/-   ##
==========================================
- Coverage   76.89%   76.88%   -0.01%     
==========================================
  Files        1005     1005              
  Lines       54169    54166       -3     
  Branches     7456     7456              
==========================================
- Hits        41653    41648       -5     
- Misses      12272    12273       +1     
- Partials      244      245       +1     
Flag Coverage Δ
javascript 71.07% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/reports/actions/reports.js 33.33% <0.00%> (-7.85%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 47.23% <0.00%> (-0.43%) ⬇️
...src/components/FilterableTable/FilterableTable.tsx 81.86% <0.00%> (-0.32%) ⬇️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 74.35% <0.00%> (ø)
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 72.22% <0.00%> (ø)
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 65.92% <0.00%> (ø)
...ontrols/AnnotationLayerControl/AnnotationLayer.jsx 83.85% <0.00%> (+0.01%) ⬆️
.../src/views/CRUD/data/savedquery/SavedQueryList.tsx 73.10% <0.00%> (+0.18%) ⬆️
...erset-frontend/src/SqlLab/components/ResultSet.tsx 63.35% <0.00%> (+0.76%) ⬆️
superset-frontend/src/reports/reducers/reports.js 75.00% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997320a...902e57f. Read the comment docs.

@villebro
Copy link
Member Author

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true

@github-actions
Copy link
Contributor

@villebro Ephemeral environment spinning up at http://34.220.179.110:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@zhaoyongjie zhaoyongjie self-requested a review September 24, 2021 13:17
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the upgrade!

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local. Tested linked superset-ui repo.
LGTM

@villebro villebro merged commit a341319 into apache:master Sep 25, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* chore: upgrade to Node 16

* add docs

* fix test
ktmud added a commit that referenced this pull request Nov 20, 2021
#16809 updated node version but it didn't update nvmrc.
villebro pushed a commit that referenced this pull request Nov 23, 2021
#16809 updated node version but it didn't update nvmrc.
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* chore: upgrade to Node 16

* add docs

* fix test
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
#16809 updated node version but it didn't update nvmrc.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants