Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: turn on SQLLAB_BACKEND_PERSISTENCE by default #19107

Merged
merged 5 commits into from
Mar 18, 2022
Merged

chore: turn on SQLLAB_BACKEND_PERSISTENCE by default #19107

merged 5 commits into from
Mar 18, 2022

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Mar 10, 2022

SUMMARY

#8060 has been in flight for a couple of years and no major issues reported from trail users (e.g. Preset), let's turn it default on in v2.0 as it can significantly improve the capacity of the SQL Lab tabs.

Will fix any remaining issues that may be reported by the community in 2.x.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

  • SQL lab tabs should be retained after turning the flag on

ADDITIONAL INFORMATION

  • Has associated issue: SIP-23: Persist SQL Lab state in the backend #8060
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@ktmud ktmud added the v2.0 label Mar 10, 2022
@ktmud ktmud force-pushed the sqllab-backend-persist-default-on branch from b48751b to 07f26bd Compare March 10, 2022 17:38
@codecov
Copy link

codecov bot commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #19107 (35ef69b) into master (51061f0) will not change coverage.
The diff coverage is n/a.

❗ Current head 35ef69b differs from pull request most recent head e9eb6a6. Consider uploading reports for the commit e9eb6a6 to get more accurate results

@@           Coverage Diff           @@
##           master   #19107   +/-   ##
=======================================
  Coverage   66.76%   66.76%           
=======================================
  Files        1670     1670           
  Lines       64392    64392           
  Branches     6499     6499           
=======================================
  Hits        42991    42991           
  Misses      19718    19718           
  Partials     1683     1683
Flag Coverage Δ
javascript 51.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 57.53% <ø> (ø)
...rset-frontend/src/components/Checkbox/Checkbox.tsx 100.00% <ø> (ø)
...uperset-frontend/src/components/Dropdown/index.tsx 100.00% <ø> (ø)
superset/config.py 91.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51061f0...e9eb6a6. Read the comment docs.

@ktmud ktmud mentioned this pull request Mar 15, 2022
Closed
9 tasks
@hughhhh hughhhh closed this Mar 15, 2022
@hughhhh hughhhh reopened this Mar 15, 2022
@ktmud ktmud force-pushed the sqllab-backend-persist-default-on branch from 07f26bd to b5d624d Compare March 17, 2022 17:00
@ktmud ktmud force-pushed the sqllab-backend-persist-default-on branch from b5d624d to 78d8025 Compare March 17, 2022 17:14
ktmud
ktmud commented Mar 17, 2022
View reviewed changes
superset-frontend/src/components/Checkbox/Checkbox.tsx
@@ -20,7 +20,7 @@ import React from 'react';
import { styled } from '@superset-ui/core';
import { CheckboxChecked, CheckboxUnchecked } from 'src/components/Checkbox';

interface CheckboxProps {
export interface CheckboxProps {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bycatch: fix this missing export. For some reason, this is causing Cypress test on SQL tabs to fail locally.

@pull-request-size pull-request-size bot added size/L and removed size/S labels Mar 17, 2022
ktmud
ktmud commented Mar 17, 2022
View reviewed changes
superset-frontend/cypress-base/cypress/integration/sqllab/tabs.test.ts
cy.visit('/superset/sqllab');
});

it('allows you to create and close a tab', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rewritten the tests for SQL Lab Tabs to make them more re-runnable---so that if you have any backend persistent tabs, the tab names are still named correctly following the logics here.

cc @cccs-Dustin @kgabryje

@ktmud ktmud force-pushed the sqllab-backend-persist-default-on branch from 79d6b86 to 6a5d178 Compare March 17, 2022 19:50
@ktmud ktmud force-pushed the sqllab-backend-persist-default-on branch from 6a5d178 to e9eb6a6 Compare March 17, 2022 19:56
@ktmud ktmud merged commit f629154 into apache:master Mar 18, 2022
@ktmud ktmud deleted the sqllab-backend-persist-default-on branch March 18, 2022 04:52
@musicmuthu
Copy link

#21122 issue after enable the sqllab_backend_persistence

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etr2460 etr2460 etr2460 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ktmud @musicmuthu @etr2460 @mistercrunch @hughhhh @michael-s-molina