-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: turn on SQLLAB_BACKEND_PERSISTENCE by default #19107
chore: turn on SQLLAB_BACKEND_PERSISTENCE by default #19107
Conversation
b48751b
to
07f26bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #19107 +/- ##
=======================================
Coverage 66.76% 66.76%
=======================================
Files 1670 1670
Lines 64392 64392
Branches 6499 6499
=======================================
Hits 42991 42991
Misses 19718 19718
Partials 1683 1683
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
07f26bd
to
b5d624d
Compare
b5d624d
to
78d8025
Compare
@@ -20,7 +20,7 @@ import React from 'react'; | |||
import { styled } from '@superset-ui/core'; | |||
import { CheckboxChecked, CheckboxUnchecked } from 'src/components/Checkbox'; | |||
|
|||
interface CheckboxProps { | |||
export interface CheckboxProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bycatch: fix this missing export. For some reason, this is causing Cypress test on SQL tabs to fail locally.
cy.visit('/superset/sqllab'); | ||
}); | ||
|
||
it('allows you to create and close a tab', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rewritten the tests for SQL Lab Tabs to make them more re-runnable---so that if you have any backend persistent tabs, the tab names are still named correctly following the logics here.
79d6b86
to
6a5d178
Compare
6a5d178
to
e9eb6a6
Compare
#21122 issue after enable the sqllab_backend_persistence |
SUMMARY
#8060 has been in flight for a couple of years and no major issues reported from trail users (e.g. Preset), let's turn it default on in v2.0 as it can significantly improve the capacity of the SQL Lab tabs.
Will fix any remaining issues that may be reported by the community in 2.x.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION