-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: turn on Versioned Export in config.py #19142
Conversation
fd95ab3
to
1f6804e
Compare
1f6804e
to
78f81d5
Compare
UPDATING.md
Outdated
@@ -37,6 +37,7 @@ assists people when migrating to a new version. | |||
- [18970](https://github.com/apache/superset/pull/18970): Changes feature | |||
flag for the legacy datasource editor (DISABLE_LEGACY_DATASOURCE_EDITOR) in config.py to True, thus disabling the feature from being shown in the client. | |||
- [19017](https://github.com/apache/superset/pull/19017): Removes Python 3.7 support. | |||
- [19142](https://github.com/apache/superset/pull/19142): Changes feature flag for versioned export(VERSIONED_EXPORT) to be true, depreciating older api endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [19142](https://github.com/apache/superset/pull/19142): Changes feature flag for versioned export(VERSIONED_EXPORT) to be true, depreciating older api endpoints. | |
- [19142](https://github.com/apache/superset/pull/19142): Changes feature flag for versioned export (VERSIONED_EXPORT) to be true, deprecating older api endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still unresolved. :)
@@ -407,7 +407,7 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]: | |||
"DASHBOARD_NATIVE_FILTERS_SET": False, | |||
"DASHBOARD_FILTERS_EXPERIMENTAL": False, | |||
"GLOBAL_ASYNC_QUERIES": False, | |||
"VERSIONED_EXPORT": False, | |||
"VERSIONED_EXPORT": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
a8da040
to
ad18fc2
Compare
3fedf25
to
c00720d
Compare
@@ -335,111 +283,6 @@ def test_import_datasets_versioned_export(import_datasets_command, app_context, | |||
import_datasets_command.assert_called_with(expected_contents, overwrite=True) | |||
|
|||
|
|||
@mock.patch.dict( | |||
"superset.config.DEFAULT_FEATURE_FLAGS", {"VERSIONED_EXPORT": False}, clear=True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try superset.cli.lib.feature_flag
instead of superset.config.DEFAULT_FEATURE_FLAGS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked offline, let's keep the unit tests.
c00720d
to
0865ab7
Compare
c6e73fb
to
8e5aa9a
Compare
89bd40b
to
49cfe3b
Compare
49cfe3b
to
ea13166
Compare
Codecov Report
@@ Coverage Diff @@
## master #19142 +/- ##
==========================================
+ Coverage 66.55% 66.56% +0.01%
==========================================
Files 1646 1668 +22
Lines 63617 64280 +663
Branches 6471 6496 +25
==========================================
+ Hits 42339 42790 +451
- Misses 19600 19808 +208
- Partials 1678 1682 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ea13166
to
ed4a851
Compare
@@ -1346,7 +1346,9 @@ def test_export(self): | |||
# freeze time to ensure filename is deterministic | |||
with freeze_time("2020-01-01T00:00:00Z"): | |||
rv = self.get_assert_metric(uri, "export") | |||
headers = generate_download_headers("json")["Content-Disposition"] | |||
headers = generate_download_headers( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leave this test unmodified and make it run with the feature flag off?
@patch.dict(
"superset.extensions.feature_flag_manager._feature_flags",
{"VERSIONED_EXPORT": False},
clear=True,
)
And maybe remove the feature flag patch from the test_export_bundle
test below on line 1406.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through and removed this feature flag patch when set to true for a couple of tests.
UPDATING.md
Outdated
@@ -37,6 +37,7 @@ assists people when migrating to a new version. | |||
- [18970](https://github.com/apache/superset/pull/18970): Changes feature | |||
flag for the legacy datasource editor (DISABLE_LEGACY_DATASOURCE_EDITOR) in config.py to True, thus disabling the feature from being shown in the client. | |||
- [19017](https://github.com/apache/superset/pull/19017): Removes Python 3.7 support. | |||
- [19142](https://github.com/apache/superset/pull/19142): Changes feature flag for versioned export(VERSIONED_EXPORT) to be true, depreciating older api endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still unresolved. :)
f39da79
to
d3905f8
Compare
d3905f8
to
eadaaa5
Compare
eadaaa5
to
59bc37d
Compare
SUMMARY
This PR turns the Versioned Export flag to true, this is a breaking change for superset 2.0
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION