-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump celery and Flask #19168
chore: bump celery and Flask #19168
Conversation
superset/dashboards/api.py
Outdated
response = send_file( | ||
buf, | ||
mimetype="application/zip", | ||
as_attachment=True, | ||
attachment_filename=filename, | ||
download_name=filename, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://flask.palletsprojects.com/en/2.0.x/api/#flask.send_file
attachment_filename
is deprecated
@@ -64,7 +74,7 @@ dnspython==2.1.0 | |||
# via email-validator | |||
email-validator==1.1.3 | |||
# via flask-appbuilder | |||
flask==1.1.4 | |||
flask==2.0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the changelog the only breaking change which may impact us is pallets/flask#3555.
Codecov Report
@@ Coverage Diff @@
## master #19168 +/- ##
==========================================
+ Coverage 66.64% 66.67% +0.03%
==========================================
Files 1674 1675 +1
Lines 64614 64612 -2
Branches 6502 6501 -1
==========================================
+ Hits 43061 43080 +19
+ Misses 19868 19848 -20
+ Partials 1685 1684 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Should we be merging this into a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # UPDATING.md # superset/cli/celery.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor leftover from a merge conflict, other than that LGTM and looking forward to getting this in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi! I noticed |
@garyng yes it's intentional, that dependency is optional on FAB 4.0.0: https://flask-appbuilder.readthedocs.io/en/latest/breaking.html#version-4-0-0 |
@dpgaspar okay, thanks! |
* chore: bump celery, Flask, flask-jwt-extended, pyJWT * fix pyJWT breaking change * fix pyJWT breaking change 2 * test * fixed test * fixed test * fixed test * revert since mypy won't pick the correct signature * lint 1 * fix test * fix test * docs and celery config migration * bump FAB to 4.0.0rc3, remove AUTH_STRICT_RESPONSE_CODES * update docs for new celery config keys * downgrade celery to 5.2.2 * ref FAB to final 4.0.0 release * remove conflict left over
SUMMARY
This PR bumps major versions on the following main packages:
Celery from 4.X to 5.X:
Breaking changes: https://docs.celeryq.dev/en/stable/history/whatsnew-5.0.html#step-5-upgrade-to-celery-5-0
Relevant CLI breaking changes, and a final "warning" to migrate configuration keys to the new standard introduced on celery 4:
https://docs.celeryq.dev/en/stable/userguide/configuration.html#conf-old-settings-map
Note: Celery is at 5.2.2 and not 5.2.3 because of celery/celery#7194 this can cause problems on newer OSes forcing setup's to pin down setuptools
Flask-AppBuilder 3.X to 4.X
AUTH_STRICT_RESPONSE_CODES
, it's always strict nowFlask-OpenID
dependency (extra dependency now)Flask from 1.X to 2.X
Breaking changes: https://flask.palletsprojects.com/en/2.0.x/changes/#version-2-0-0
Relevant:
JSON support no longer uses simplejson. To use another JSON module, override app.json_encoder and json_decoder. #3555
send_file() raises a ValueError when passed an io object in text mode. Previously, it would respond with 200 OK and an empty file. #3358
No relevant changes for our users, unless using a customised/extended Superset.
flask-jwt-extended 3.X to 4.X:
Breaking changes: https://flask-jwt-extended.readthedocs.io/en/stable/v4_upgrade_guide/
No relevant changes for our users, unless using a customised Security Manager that uses this extension JWT claims or using
JWT_CSRF_HEADER_NAME
configuration key.pyJWT 1.X to 2.X:
Breaking changes: https://pyjwt.readthedocs.io/en/stable/changelog.html#v2-0-0
No relevant changes for our users, unless using a customised/extended Superset.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION