-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add samples endpoint #20170
feat: add samples endpoint #20170
Conversation
8be4d8c
to
6ef25bb
Compare
Looks great @zhaoyongjie ! Can we add a few simple tests? |
Sure, I will do. |
Codecov Report
@@ Coverage Diff @@
## master #20170 +/- ##
==========================================
- Coverage 66.44% 66.27% -0.18%
==========================================
Files 1721 1722 +1
Lines 64548 64605 +57
Branches 6811 6811
==========================================
- Hits 42890 42815 -75
- Misses 19925 20057 +132
Partials 1733 1733
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
9c874b2
to
8475771
Compare
c8ece6a
to
21f7d66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second pass comments, mostly nits
Co-authored-by: Ville Brofeldt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I look forward to getting rid of samples in the regular chart data endpoint!
SUMMARY
Add a new samples endpoint for getting dataset sampling
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
superset init
http://localhost:9000/api/v1/dataset/<dataset_id>/samples
in browserhttp://localhost:9000/api/v1/dataset/<dataset_id>/samples?force=true
to force queryADDITIONAL INFORMATION