-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecate approve and request_access endpoint #22022
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22022 +/- ##
===========================================
- Coverage 66.97% 55.48% -11.50%
===========================================
Files 1815 1815
Lines 69540 69542 +2
Branches 7483 7483
===========================================
- Hits 46575 38585 -7990
- Misses 21034 29026 +7992
Partials 1931 1931
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I wonder if Airbnb are still using these internally? Ping @john-bodley
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Michael S. Molina <[email protected]>
Co-authored-by: Michael S. Molina <[email protected]>
Co-authored-by: Michael S. Molina <[email protected]>
Co-authored-by: Michael S. Molina <[email protected]>
Co-authored-by: Michael S. Molina <[email protected]> (cherry picked from commit 358a4ec)
SUMMARY
Changes both
/superset/approve
and/superset/request_access
to HTTP POST.Since these endpoints change the state of the system GET is not correct
ADDITIONAL INFORMATION