-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(reports): change default executor to owner #22799
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22799 +/- ##
=======================================
Coverage 68.31% 68.31%
=======================================
Files 1951 1951
Lines 75385 75385
Branches 8185 8185
=======================================
Hits 51496 51496
Misses 21786 21786
Partials 2103 2103
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@villebro This is great, and we're looking forward to testing it out. I assume that this is a 3.0 chore, and we should merge this when the branch opens up for breaking changes, but if someone wants to test out the functionality now, they would only need to change this config? |
@eschutho Yes, I think it's a good idea to slot this for 3.0. I'll tag it accordingly. And by changing the config as as proposed above you can opt in to this behavior. |
fa71238
to
71b87c9
Compare
If this is considered breaking, we should put it on the 3.0 project board and seek lazy consensus. The merge window is open! |
- [23651](https://github.com/apache/superset/pull/23651): Removes UX_BETA feature flag. | ||
- [23663](https://github.com/apache/superset/pull/23663): Removes deprecated feature flags `ALLOW_DASHBOARD_DOMAIN_SHARDING`, `DISPLAY_MARKDOWN_HTML`, and `FORCE_DATABASE_CONNECTIONS_SSL`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bycatch: the colon was missing after the link
SUMMARY
This changes Alerts & Reports to execute as the primary owner of the alert/report by default. In cases where there are multiple owners, the last modifier and creator are given priority in this order, otherwise the first owner will be used. This option was introduced in #21931.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION