-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(thumbnails): change default executor to logged in user #22801
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22801 +/- ##
==========================================
+ Coverage 66.70% 68.31% +1.60%
==========================================
Files 1951 1951
Lines 75385 75385
Branches 8185 8185
==========================================
+ Hits 50283 51496 +1213
+ Misses 22999 21786 -1213
Partials 2103 2103
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 89 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1f0294b
to
23b8c08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
This changes Thumbnails to execute as the currently logged in user by default, and fall back to the Selenium user for anonymous users (=when there is no logged in user). This option was introduced in #22328
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION