-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Removes the UX_BETA feature flag #23651
chore: Removes the UX_BETA feature flag #23651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -459,7 +459,6 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]: | |||
# Allow users to export full CSV of table viz type. | |||
# This could cause the server to run out of memory or compute. | |||
"ALLOW_FULL_CSV_EXPORT": False, | |||
"UX_BETA": False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for future feature flag removals: we should always try to enable FFs by default a good time in advance of removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed 👍🏼
Codecov Report
@@ Coverage Diff @@
## master #23651 +/- ##
==========================================
- Coverage 68.08% 68.08% -0.01%
==========================================
Files 1920 1920
Lines 73990 73990
Branches 8092 8091 -1
==========================================
- Hits 50379 50374 -5
- Misses 21540 21547 +7
+ Partials 2071 2069 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
caef461
to
fc97277
Compare
fc97277
to
1a552de
Compare
SUMMARY
Removes the
UX_BETA
feature flag.This is a task of the Superset 3.0 initiative.
ADDITIONAL INFORMATION