Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes the UX_BETA feature flag #23651

Merged
merged 5 commits into from
Apr 13, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Removes the UX_BETA feature flag.

This is a task of the Superset 3.0 initiative.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added risk:breaking-change Issues or PRs that will introduce breaking changes v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels Apr 11, 2023
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -459,7 +459,6 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
# Allow users to export full CSV of table viz type.
# This could cause the server to run out of memory or compute.
"ALLOW_FULL_CSV_EXPORT": False,
"UX_BETA": False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for future feature flag removals: we should always try to enable FFs by default a good time in advance of removal.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed 👍🏼

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #23651 (0a261ef) into master (0974fa1) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

❗ Current head 0a261ef differs from pull request most recent head 1a552de. Consider uploading reports for the commit 1a552de to get more accurate results

@@            Coverage Diff             @@
##           master   #23651      +/-   ##
==========================================
- Coverage   68.08%   68.08%   -0.01%     
==========================================
  Files        1920     1920              
  Lines       73990    73990              
  Branches     8092     8091       -1     
==========================================
- Hits        50379    50374       -5     
- Misses      21540    21547       +7     
+ Partials     2071     2069       -2     
Flag Coverage Δ
hive 53.18% <100.00%> (ø)
javascript 54.09% <0.00%> (-0.02%) ⬇️
mysql 79.21% <100.00%> (ø)
postgres 79.29% <100.00%> (ø)
presto 53.09% <100.00%> (ø)
python 83.14% <100.00%> (ø)
sqlite 77.78% <100.00%> (ø)
unit 53.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...ontrols/DndColumnSelectControl/DndFilterSelect.tsx 42.27% <0.00%> (ø)
...ontrols/DndColumnSelectControl/DndMetricSelect.tsx 47.86% <0.00%> (+0.40%) ⬆️
superset/config.py 91.86% <ø> (ø)
superset/connectors/base/models.py 87.24% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina changed the title refactor: Removes the UX_BETA feature flag chore: Removes the UX_BETA feature flag Apr 11, 2023
@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 12, 2023
@michael-s-molina michael-s-molina merged commit 04bd528 into apache:master Apr 13, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants