-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: bump to Python3.9 #23890
feat!: bump to Python3.9 #23890
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23890 +/- ##
==========================================
+ Coverage 68.19% 68.21% +0.02%
==========================================
Files 1941 1941
Lines 75277 75302 +25
Branches 8166 8166
==========================================
+ Hits 51333 51371 +38
+ Misses 21855 21842 -13
Partials 2089 2089
Flags with carried forward coverage won't be shown. Click here to find out more. see 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@sebastianliebscher is adding quotes around the python version the "correct" way? It would be nice to add a note about that in the description. |
@villebro Without the quotes, e.g. |
Thanks @sebastianliebscher - makes sense 👍 |
05d4526
to
d241fe0
Compare
007598b
to
8362bb9
Compare
8362bb9
to
9852d9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few quick comments
bce4936
to
8a180ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thank you @sebastianliebscher this is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, exciting! 🚀 @sebastianliebscher let's rebase to restart CI
Also many thanks to @EugeneTorap, great team effort :) |
7b9f63f
to
708b000
Compare
708b000
to
3b7e1f9
Compare
This reverts commit e3719a1.
I marked this as a breaking change. All good for now since we can get it into the 3.0 release. |
@@ -46,6 +46,7 @@ assists people when migrating to a new version. | |||
- [21163](https://github.com/apache/superset/pull/21163): The time grain will be decoupled from the time filter column and the time grain control will move below the X-Axis control when `GENERIC_CHART_AXES` feature flags set to `True`. The time grain will be applied on the time column in the column-like controls(x axis, dimensions) instead of the time column in the time section. | |||
- [21284](https://github.com/apache/superset/pull/21284): The non-functional `MAX_TABLE_NAMES` config key has been removed. | |||
- [21794](https://github.com/apache/superset/pull/21794): Deprecates the undocumented `PRESTO_SPLIT_VIEWS_FROM_TABLES` feature flag. Now for Presto, like other engines, only physical tables are treated as tables. | |||
- [23890](https://github.com/apache/superset/pull/23890): Removes Python 3.8 support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to create a PR to update this file for 2.1, so I'll move this into Breaking Changes then.
SUMMARY
Running CI integration and unit tests for Python 3.9 is a first step to fully upgrade official release to Python 3.10.
This PR bumps Python to version 3.9:
Also, added double quotes around
strategy.matrix.python-versions
values as without quotes, e.g.3.10
is interpreted as3.1
reference to GitHub Actions DocTESTING INSTRUCTIONS
All existing and new CI jobs run without errors.