-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Removes the Multiple Line Charts #23933
feat: Removes the Multiple Line Charts #23933
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23933 +/- ##
==========================================
+ Coverage 67.84% 68.53% +0.68%
==========================================
Files 1944 1941 -3
Lines 75328 75221 -107
Branches 8218 8216 -2
==========================================
+ Hits 51110 51554 +444
+ Misses 22107 21555 -552
- Partials 2111 2112 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 39 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cfdc5c8
to
8a3e22e
Compare
@michael-s-molina from a UX perspective if a user is presented with this message there's no real clear way forward, i.e., they're not able to see what the legacy chart looks like and thus can't easily recreate it in a different form. Rather than simply deleting the chart type, would it be preferable to provide a toast which states that this chart type is deprecated and will be removed in Superset 4.0. Additionally the toast should mention that the chart must be manually migrated. |
@john-bodley This chart type was marked as deprecated in a previous major version and people had more than a year to migrate from it. It's related to a 2.0 -> 3.0 cycle as opposed to 3.0 -> 4.0. |
8a3e22e
to
0e40389
Compare
0e40389
to
6cdcd20
Compare
SUMMARY
This PR removes the Multiple Line Charts.
The Multiple Line Charts description says that it's deprecated and people should use the Mixed chart instead. The problem is that Multiple Line Charts allows you to select 2 charts which may reference different datasets while Mixed Chart only allows 1 dataset. This means that to compare values from different datasets using a Mixed chart you would need to create another dataset combining the source datasets. Given that this chart is marked as deprecated for a long time, a migration would required significant effort, and its adoption is pretty low, we decided to remove it. If someone still has this chart and tries to access it, the following screen will be displayed:
AFTER SCREENSHOT
TESTING INSTRUCTIONS
1 - Make sure all Multiple Line Charts were removed
2 - Make sure Multiple Line Charts is not available anymore in the viz picker
ADDITIONAL INFORMATION