-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update QUERY_LOGGER and SQL_QUERY_MUTATOR signatures #24029
chore: Update QUERY_LOGGER and SQL_QUERY_MUTATOR signatures #24029
Conversation
63d509b
to
211cc0c
Compare
Codecov Report
@@ Coverage Diff @@
## master #24029 +/- ##
==========================================
- Coverage 68.30% 68.30% -0.01%
==========================================
Files 1952 1952
Lines 75432 75431 -1
Branches 8191 8191
==========================================
- Hits 51521 51520 -1
Misses 21807 21807
Partials 2104 2104
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the cleanup @john-bodley. I left a comment but other then that LGTM.
UPDATING.md
Outdated
@@ -24,6 +24,7 @@ assists people when migrating to a new version. | |||
|
|||
## Next | |||
|
|||
- [24029](https://github.com/apache/superset/pull/24029) Removes the `user` and `username` arguments for the QUERY_LOGGER and SQL_QUERY_MUTATOR methods respectively. If the username for the current user is required the `superset.utils.core.get_username` method should be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this to the Breaking Changes section?
7f39800
to
d97b776
Compare
fab5ad7
to
86eaed5
Compare
@john-bodley I'm just tagging this with risk:breaking-change for anyone that might be overriding the config. |
@michael-s-molina should we put something in the UPDATING file for 3.0 on this, too? This broke our integration, so maybe having the change in updating could help other people upgrading as well b/c they will have to import the user into their config overwrite from global now. |
Definitely. I think there was a miscommunication in the review because there's breaking change text added in this PR but it seems it's not related to the particular change. |
@eschutho @john-bodley I added the breaking change text here. |
SUMMARY
This PR addresses Superset 3.0 task #45.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION