-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump to Python3.10 #24112
chore: Bump to Python3.10 #24112
Conversation
# Conflicts: # .github/workflows/docker_build_push.sh # Dockerfile
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24112 +/- ##
==========================================
+ Coverage 69.71% 69.72% +0.01%
==========================================
Files 1920 1912 -8
Lines 75234 74920 -314
Branches 8423 8313 -110
==========================================
- Hits 52447 52239 -208
+ Misses 20725 20636 -89
+ Partials 2062 2045 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@betodealmeida, @eschutho, @michael-s-molina, @villebro et al. do we have a policy in terms of what versions of Python we support (I wasn’t able to find anything in the repo via a quick code search)? If not we probably should formalize this, i.e.,
|
Agree, @john-bodley, we should have this formalized. My suggestions would be every major version of Superset should support the latest 3 major versions of Python available at the time (so 3.9-3.11 today), and probably when 4.0 is out we'll support 3.10-3.12. |
This is a great topic for the next Town Hall @rusackas |
@michael-s-molina Is there any decision made on officially supported Python versions? It would be great if this is also officially documented. If there is no decision made yet then I would like to resubmit this PR. Please let me know if any concerns. |
# Conflicts: # .github/workflows/docker_build_push.sh # requirements/development.txt # requirements/testing.txt
Hi @betodealmeida @john-bodley @michael-s-molina @mdeshmu We have a problem with |
@EugeneTorap I will follow up on the bug. Someone said here that combination of prophet 1.1.4 and holidays 0.32 is working. Can you check that? Also, there is another potential Redis issue with Python 3.11. |
@EugeneTorap prophet 1.1.5 is released and someone said here it works for them: facebook/prophet#2354 (comment) |
Thanks @mdeshmu for this information! Can you create a small PR to update the prophet to version 1.1.5? |
Nice! Oh one more thing, can you add an entry on Otherwise LGTM, but for something that important we could use more approvals. |
@john-bodley @villebro @dpgaspar @rusackas can you also approve & merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
setup.py
Outdated
@@ -208,13 +208,12 @@ def get_git_sha() -> str: | |||
"starrocks": ["starrocks>=1.0.0"], | |||
"doris": ["pydoris>=1.0.0, <2.0.0"], | |||
}, | |||
python_requires="~=3.9", | |||
python_requires="~=3.9", # TODO: change it to "~=3.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this just now, can we make it
python_requires="~=3.9", # TODO: change it to "~=3.10" | |
python_requires="~=3.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is breaking change for folks using Python 3.9. It should become a proposal for the next breaking window.
@michael-s-molina thanks for reviewing, I suspected this would be the case.. In that case, I propose the following:
Thoughts? |
That would work.
Added here. |
Ok, so main / published docker builds start pointing to
I noticed we have a lot of "matrix" in GHA that are 3.9 only, would we want to have some or all of those do both? I wish we could DRY those up and have more consistency there.... The fact that this PR touches ~30 files to change the main python version is a bit insane (and due to GHA not having good variable/templating options for this type of stuff) |
This reverts commit 4538a7b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the suggested changes. Surprising how editing on-the-web is pretty viable now with GitHub.
@michael-s-molina I'll need an approval from you to merge since you're still in "Request changes" from a previous review
Co-authored-by: Maxime Beauchemin <[email protected]>
Co-authored-by: Maxime Beauchemin <[email protected]>
Co-authored-by: Maxime Beauchemin <[email protected]>
Co-authored-by: Maxime Beauchemin <[email protected]>
SUMMARY
Running CI integration and unit tests for Py3.10 and Py3.11.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION