-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: db validate parameters permission #24185
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24185 +/- ##
=======================================
Coverage 57.24% 57.24%
=======================================
Files 1957 1957
Lines 75624 75624
Branches 8223 8223
=======================================
Hits 43294 43294
Misses 30222 30222
Partials 2108 2108
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update any of the tests? Or add a new one?
Good point! probably a test to make sure Gamma user's don't access these. I'll add it |
@dpgaspar why are we changing these from Maybe providing a more detailed PR description would be helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix 👍
@dpgaspar Can you add a note in the Breaking Changes section for this change? |
SUMMARY
Restricts access to:
/api/v1/database/validate_parameters/
, changes the necessary permission fromcan_read
tocan_write
onDatabase
/api/v1/database/test_connection/
, changes the necessary permission fromcan_read
tocan_write
onDatabase
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION