Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated api /superset/datasources #24333

Merged
merged 7 commits into from
Jun 12, 2023

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jun 9, 2023

SUMMARY

Removes old deprecated API /superset/datasources/ use /api/v1/dataset/ instead

First PR on the effort on removing deprecated API from /superset: #24332

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #24333 (d1a1b35) into master (0e3f1f6) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head d1a1b35 differs from pull request most recent head 8b253c8. Consider uploading reports for the commit 8b253c8 to get more accurate results

@@            Coverage Diff             @@
##           master   #24333      +/-   ##
==========================================
- Coverage   69.09%   69.09%   -0.01%     
==========================================
  Files        1903     1903              
  Lines       74608    74602       -6     
  Branches     8107     8107              
==========================================
- Hits        51550    51545       -5     
+ Misses      20947    20946       -1     
  Partials     2111     2111              
Flag Coverage Δ
hive 53.78% <ø> (-0.01%) ⬇️
mysql 79.39% <ø> (-0.01%) ⬇️
postgres 79.46% <ø> (-0.01%) ⬇️
presto 53.71% <ø> (-0.01%) ⬇️
python 83.38% <ø> (+<0.01%) ⬆️
sqlite 77.99% <ø> (-0.01%) ⬇️
unit 54.20% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 76.21% <ø> (-0.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpgaspar dpgaspar requested a review from a team June 9, 2023 00:53
UPDATING.md Outdated
@@ -24,6 +24,7 @@ assists people when migrating to a new version.

## Next

- [24333](https://github.com/apache/superset/pull/24333): Removed deprecated API `/superset/datasources`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to the Breaking Changes section and add the PR number?

@dpgaspar dpgaspar requested review from villebro and geido June 12, 2023 08:30
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit 3d9c7d4 into apache:master Jun 12, 2023
29 checks passed
@dpgaspar dpgaspar deleted the chore/remove-deprecated-apis branch June 12, 2023 12:07
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants