-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove deprecated api /superset/filter/... #24335
chore: remove deprecated api /superset/filter/... #24335
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24335 +/- ##
==========================================
+ Coverage 67.42% 69.08% +1.66%
==========================================
Files 1903 1903
Lines 74604 74590 -14
Branches 8107 8107
==========================================
+ Hits 50301 51534 +1233
+ Misses 22192 20945 -1247
Partials 2111 2111
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 95 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
UPDATING.md
Outdated
@@ -24,6 +24,7 @@ assists people when migrating to a new version. | |||
|
|||
## Next | |||
|
|||
- [---](https://github.com/apache/superset/pull/---): Removed deprecated API `/superset/filter/<datasource_type>/<int:datasource_id>/<column>/` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this to the Breaking Changes section and add the PR number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
Removes old deprecated API
/superset/filter/<datasource_type>/<int:datasource_id>/<column>/
use/api/v1/datasource/<datasource_type>/<datasource_id>/column/<column_name>/values/
insteadFirst PR on the effort on removing deprecated API from
/superset
: #24332BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION