-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove deprecated api /superset/tables/<int:db_id>/... #24342
chore: remove deprecated api /superset/tables/<int:db_id>/... #24342
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24342 +/- ##
==========================================
- Coverage 69.08% 69.06% -0.03%
==========================================
Files 1903 1903
Lines 74590 74564 -26
Branches 8107 8107
==========================================
- Hits 51534 51500 -34
- Misses 20945 20953 +8
Partials 2111 2111
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
UPDATING.md
Outdated
@@ -24,6 +24,7 @@ assists people when migrating to a new version. | |||
|
|||
## Next | |||
|
|||
- [-](https://github.com/apache/superset/pull/-): Removed deprecated API `/superset/tables/<int:db_id>/<schema>/...` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this to the breaking changes section and add the PR number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is strange I think we used to only have Next
and potential downtime, since all that lands on Next
would somewhat be a minor breaking change. What's the difference between Next
and Breaking changes
on this context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference is that in Next we add things that are not breaking changes but might be helpful when upgrading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is just a form of separating things you should really be careful when upgrading from things you might find useful or interesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I suggest we wait for #24344 first and make sure the perf issue is fixed on both code paths before merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
Removes old deprecated API
/superset/tables/<int:db_id>/...
use/api/v1/database/<int:pk>/tables/
insteadEffort on removing deprecated APIs from
/superset
: #24332BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION